Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-45545

CSS chunker does not handle commas in media queries

    XMLWordPrintable

Details

    • MOODLE_25_STABLE, MOODLE_26_STABLE, MOODLE_27_STABLE
    • MOODLE_25_STABLE, MOODLE_26_STABLE, MOODLE_27_STABLE
      1. Run the unit tests for lib/tests/csslib_test.php

    Description

      It does not have much implications, but it is considering a comma in a media query as a selector which is not right.

      I discovered that I missed that while reviewing MDL-45535.

      Doc: https://developer.mozilla.org/en-US/docs/Web/Guide/CSS/Media_queries

      Attachments

        Issue Links

          has been marked as being related by

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-45535 CSS chunking breaks media rules if CSS invalid (IE)

          • Minor - Minor loss of function where workaround is possible
          • Closed

          Activity

            People

              fred Frédéric Massart
              fred Frédéric Massart
              Andrew Lyons Andrew Lyons
              Dan Poltawski Dan Poltawski
              Simey Lameze Simey Lameze
              Amy Groshek, David Scotson, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Laurent David, Sara Arjona (@sarjona), Huong Nguyen, Bas Brands, Mathew May
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                14/Jul/14