[MDL-45545] CSS chunker does not handle commas in media queries - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 2.5.6, 2.6.3, 2.7
Fix Version/s: 2.5.7, 2.6.4, 2.7.1
Component/s: HTML and CSS, Themes
Labels:
- ci
- regression
- triaged

Testing Instructions:
1. Run the unit tests for lib/tests/csslib_test.php
Affected Branches:
MOODLE_25_STABLE, MOODLE_26_STABLE, MOODLE_27_STABLE
Fixed Branches:
MOODLE_25_STABLE, MOODLE_26_STABLE, MOODLE_27_STABLE
Pull from Repository:
git://github.com/FMCorz/moodle.git

Description

It does not have much implications, but it is considering a comma in a media query as a selector which is not right.

I discovered that I missed that while reviewing ~~MDL-45535~~.

Doc: https://developer.mozilla.org/en-US/docs/Web/Guide/CSS/Media_queries

Attachments

Issue Links

has been marked as being related by

MDL-45535 CSS chunking breaks media rules if CSS invalid (IE)

Closed

Activity

People

Assignee:: Frédéric Massart

Reporter:: Frédéric Massart

Peer reviewer:: Andrew Lyons

Integrator:: Dan Poltawski

Tester:: Simey Lameze

Participants:: Andrew Lyons, CiBoT, Dan Poltawski, Eloy Lafuente (stronk7), Frédéric Massart, Simey Lameze

Component watchers:: Amy Groshek, David Scotson, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona), Bas Brands

Votes:: 0 Vote for this issue

Watchers:: 3 Start watching this issue

Dates

Created:: 14/May/14 11:14 PM

Updated:: 23/May/14 9:42 AM

Resolved:: 23/May/14 9:42 AM

Fix Release Date:: 14/Jul/14