Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-45545

CSS chunker does not handle commas in media queries

    XMLWordPrintable

    Details

    • Testing Instructions:
      1. Run the unit tests for lib/tests/csslib_test.php
    • Affected Branches:
      MOODLE_25_STABLE, MOODLE_26_STABLE, MOODLE_27_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE, MOODLE_26_STABLE, MOODLE_27_STABLE
    • Pull from Repository:

      Description

      It does not have much implications, but it is considering a comma in a media query as a selector which is not right.

      I discovered that I missed that while reviewing MDL-45535.

      Doc: https://developer.mozilla.org/en-US/docs/Web/Guide/CSS/Media_queries

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              fred Frédéric Massart
              Reporter:
              fred Frédéric Massart
              Peer reviewer:
              Andrew Nicols
              Integrator:
              Dan Poltawski
              Tester:
              Simey Lameze
              Participants:
              Component watchers:
              Amy Groshek, David Scotson, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón, Bas Brands
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                14/Jul/14