Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-45568

Incorrect description for the course module completion event

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. Visit <yoursite>/admin/settings.php?section=managelogging and enable the 'Standard log' and disable the 'Legacy log'.
      2. Visit <yoursite>/admin/settings.php?section=optionalsubsystems and enable completion tracking.
      3. Visit a course and enable completion tracking.
      4. Create an activity that has 'Completion tracking' set to 'Show activity as complete when conditions are met' and check 'Require view'.
      5. Enrol a user into a course.
      6. Visit the course as the student and view the activity.
      7. As an administration visit "<yoursite>/report/log/index.php" and view the 'Site logs'.
      8. For the event 'Course module completion updated' ensure the event description makes sense and matches the diff.
      Show
      Visit <yoursite>/admin/settings.php?section=managelogging and enable the 'Standard log' and disable the 'Legacy log'. Visit <yoursite>/admin/settings.php?section=optionalsubsystems and enable completion tracking. Visit a course and enable completion tracking. Create an activity that has 'Completion tracking' set to 'Show activity as complete when conditions are met' and check 'Require view'. Enrol a user into a course. Visit the course as the student and view the activity. As an administration visit "<yoursite>/report/log/index.php" and view the 'Site logs'. For the event 'Course module completion updated' ensure the event description makes sense and matches the diff.
    • Affected Branches:
      MOODLE_27_STABLE
    • Fixed Branches:
      MOODLE_27_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-45568_master

      Description

      I logged in as a student (user id '3') and manually marked activity as completed.

      In the log I can see:
      Event name: Course module completion updated
      Description: The course module completion requirements were updated by the user with id '3' for the user with id '3'.

      This is not correct. Correct would be:
      "Course module completion state was updated for the user with id '$relateduserid'"
      or
      "The user with id '$userid' updated course module completion for the user with id '$relateduserid'"
      (we can not say "user completed" because the same event is triggered when user unticks completion box)

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              markn Mark Nelson
              Reporter:
              marina Marina Glancy
              Peer reviewer:
              Ankit Agarwal
              Integrator:
              Damyon Wiese
              Tester:
              Michael de Raadt
              Participants:
              Component watchers:
              Sam Marshall, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                14/Jul/14