Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-45580

PDF Annotations Remain After PDF is Replaced

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Along this test, use PDFs with different number of pages, and check each page of the PDF

      • Offline version means: The link to download the annotated PDF
      • Online version means: The "View annotated PDF" button
      • Annotate the PDF means: As a teacher, click "Launch PDF editor" on the grading page (not quickgrading)
      • Refresh the page between launches of the online or annotate actions (there is a Javascript cache going on)

      Before upgrade

      1. Create an assignment with file submissions
      2. With 2 students, submit a PDF as your submission
      3. As a teacher, annotate the PDF of student A

      Upgrade

      1. Login as student A
      2. Go to the assignment and view the online version
      3. Make sure you can view the online annotated PDF and it matches the offline version
      4. Clean your browser's cache
      5. Update your submission and replace the PDF with another one
      6. View the online version again, and make sure it has not changed
      7. Login as a teacher
      8. View both the online and offline annotated PDF
      9. Make sure both display the original PDF, not the new one, with the annotations
      10. Go grade the student and annotate the PDF
      11. Make sure that the latest submission is displayed
      12. Make sure the annotations are gone
      13. Make some changes, but do NOT save
      14. As the student A, confirm that the online PDF has not changed
      15. As the teacher, resume annotating the PDF and save
      16. Still as the teacher check the annotated PDF (offline and online)
      17. Make sure it matches your latest annotated PDF
      18. Login as the student, and check that the online/offline annotated PDF is up-to-date
      19. Login as the teacher, and annotate the PDF of student B
      20. Make sure both the teacher and the student can see the online/offline version
      21. Update your submission as student B (use a different PDF)
      22. Make sure it did not affect the online/offiline version for both student and teacher
      23. As the teacher, annotate the PDF of student B
      24. Make sure the latest submission of the student is used
      25. Make sure all your previous annotations are gone

      Backup/restore

      1. Backup an assignment activity in which you annotated a PDF
      2. Restore in another course
      3. Make sure the student and teacher can access the online/offline version of the annotated PDF
      Show
      Along this test, use PDFs with different number of pages, and check each page of the PDF Offline version means: The link to download the annotated PDF Online version means: The "View annotated PDF" button Annotate the PDF means: As a teacher, click "Launch PDF editor" on the grading page (not quickgrading) Refresh the page between launches of the online or annotate actions (there is a Javascript cache going on) Before upgrade Create an assignment with file submissions With 2 students, submit a PDF as your submission As a teacher, annotate the PDF of student A Upgrade Login as student A Go to the assignment and view the online version Make sure you can view the online annotated PDF and it matches the offline version Clean your browser's cache Update your submission and replace the PDF with another one View the online version again, and make sure it has not changed Login as a teacher View both the online and offline annotated PDF Make sure both display the original PDF, not the new one, with the annotations Go grade the student and annotate the PDF Make sure that the latest submission is displayed Make sure the annotations are gone Make some changes, but do NOT save As the student A, confirm that the online PDF has not changed As the teacher, resume annotating the PDF and save Still as the teacher check the annotated PDF (offline and online) Make sure it matches your latest annotated PDF Login as the student, and check that the online/offline annotated PDF is up-to-date Login as the teacher, and annotate the PDF of student B Make sure both the teacher and the student can see the online/offline version Update your submission as student B (use a different PDF) Make sure it did not affect the online/offiline version for both student and teacher As the teacher, annotate the PDF of student B Make sure the latest submission of the student is used Make sure all your previous annotations are gone Backup/restore Backup an assignment activity in which you annotated a PDF Restore in another course Make sure the student and teacher can access the online/offline version of the annotated PDF
    • Affected Branches:
      MOODLE_26_STABLE
    • Fixed Branches:
      MOODLE_26_STABLE, MOODLE_27_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-45580-master
    • Story Points:
      20
    • Sprint:
      FRONTEND Sprint 12

      Description

      When a student edits an assignment submission and deletes a PDF that was already annotated by the teacher and then adds a new PDF submission, the annotations given by the teacher for the old PDF remain in the new PDF.

      Steps to reproduce:

      1. In any course, create an Assignment that allows file submissions.
      2. As a student, submit a PDF file for the assignment.
      3. As a teacher, annotate the student's PDF submission and save.
      4. As the student, return to the assignment and click Edit Submission.
      5. Delete the existing PDF file and upload a new PDF file. Save changes.
      6. As the teacher, access assignment and click View/grade All Submissions.
      7. Click Grade icon under Grade column for the same student.
      8. Launch PDF editor and observe

      Expected results: Annotations from the old PDF file should not display in the new PDF submission.

      Actual results: Annotations from the old PDF file are retained and display in the newly submitted PDF file.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              fred Frédéric Massart
              Reporter:
              cfollin Chris Follin
              Peer reviewer:
              Andrew Davis
              Integrator:
              Damyon Wiese
              Tester:
              John Okely
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
              Votes:
              1 Vote for this issue
              Watchers:
              6 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                14/Jul/14