Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-45603

Cache mappingsonly doesn't actually work

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.7
    • Fix Version/s: 2.5.7, 2.6.4, 2.7.1
    • Component/s: Caching
    • Labels:

      Description

      Based on the description, if mappingsonly is true, the cache shouldn't work if the admin hasn't explicitly set a cache store for the cache.

      To me, this would be helpful if you are doing something that should be faster fetching from the DB over the default file based store, but you want to allow admins to switch it to something very fast/low load like memcached.

      When mappingsonly it set, cache_config->get_stores_for_definition() properly returns no stores, but cache_helper->get_stores_suitable_for_definition() assumes that the lack for stores is unintentional (the assigned caches are unavailable) and adds the default store back in.

        Attachments

          Activity

            People

            Assignee:
            emerrill Eric Merrill
            Reporter:
            emerrill Eric Merrill
            Peer reviewer:
            Ankit Agarwal
            Integrator:
            Sam Hemelryk
            Tester:
            Jetha Chan
            Participants:
            Component watchers:
            Matteo Scaramuccia, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)
            Votes:
            1 Vote for this issue
            Watchers:
            4 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              14/Jul/14