Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-45625

Deprecate old forum functions

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.7
    • Fix Version/s: 2.8
    • Component/s: Forum
    • Labels:
    • Testing Instructions:
      Hide
      • Run phpunit and behat
      • Attempt colourful git greps for each of the removed functions:

        function forum_count_unrated_posts($discussionid, $userid) {
        function forum_tp_count_discussion_read_records($userid, $discussionid) {
        function forum_get_user_discussions($courseid, $userid, $groupid=0) {
        function forum_tp_count_forum_posts($forumid, $groupid=false) {
        function forum_tp_count_forum_read_records($userid, $forumid, $groupid=false) {
        function forum_get_open_modes() {
        function forum_get_child_posts($parent, $forumid) {
        function forum_get_discussion_posts($discussion, $sort, $forumid) {
        function forum_get_ratings($context, $postid, $sort = "u.firstname ASC") {
        function forum_get_tracking_link($forum, $messages=array(), $fakelink=true) {
        function forum_tp_count_discussion_unread_posts($userid, $discussionid) {
        function forum_convert_to_roles() {
        function forum_tp_get_read_records($userid=-1, $postid=-1, $discussionid=-1, $forumid=-1) {
        function forum_tp_get_discussion_read_records($userid, $discussionid) {
        function forum_user_enrolled($cp) {
        function forum_user_can_view_post($post, $course, $cm, $forum, $discussion, $user=null){
        function forum_shorten_post($message) {
        

      Show
      Run phpunit and behat Attempt colourful git greps for each of the removed functions: function forum_count_unrated_posts($discussionid, $userid) { function forum_tp_count_discussion_read_records($userid, $discussionid) { function forum_get_user_discussions($courseid, $userid, $groupid=0) { function forum_tp_count_forum_posts($forumid, $groupid=false) { function forum_tp_count_forum_read_records($userid, $forumid, $groupid=false) { function forum_get_open_modes() { function forum_get_child_posts($parent, $forumid) { function forum_get_discussion_posts($discussion, $sort, $forumid) { function forum_get_ratings($context, $postid, $sort = "u.firstname ASC") { function forum_get_tracking_link($forum, $messages=array(), $fakelink=true) { function forum_tp_count_discussion_unread_posts($userid, $discussionid) { function forum_convert_to_roles() { function forum_tp_get_read_records($userid=-1, $postid=-1, $discussionid=-1, $forumid=-1) { function forum_tp_get_discussion_read_records($userid, $discussionid) { function forum_user_enrolled($cp) { function forum_user_can_view_post($post, $course, $cm, $forum, $discussion, $user=null){ function forum_shorten_post($message) {
    • Affected Branches:
      MOODLE_27_STABLE
    • Fixed Branches:
      MOODLE_28_STABLE
    • Pull Master Branch:
      MDL-45625-master

      Description

      Looking at MDL-39707 I've comes across a number of functions which have been deprecated without being marked as such. Some of them since 2003. Time to remove them.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              dobedobedoh Andrew Nicols
              Reporter:
              dobedobedoh Andrew Nicols
              Peer reviewer:
              Marina Glancy
              Integrator:
              Sam Hemelryk
              Tester:
              Rajesh Taneja
              Participants:
              Component watchers:
              Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                10/Nov/14