Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-45629

The submission_status_viewed event uses invalid objectid

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. Go to <yoursite>/admin/settings.php?section=managelogging and enable 'Standard log' and disable 'Legacy log'.
      2. Create an assignment.
      3. View the assignment as a student.
      4. Go to <yoursite>/report/log/index.php, view the 'Site logs' and check that the description for the event "The status of the submission has been viewed." makes sense and does not contain empty quotes.
      Show
      Go to <yoursite>/admin/settings.php?section=managelogging and enable 'Standard log' and disable 'Legacy log'. Create an assignment. View the assignment as a student. Go to <yoursite>/report/log/index.php, view the 'Site logs' and check that the description for the event "The status of the submission has been viewed." makes sense and does not contain empty quotes.
    • Affected Branches:
      MOODLE_27_STABLE
    • Fixed Branches:
      MOODLE_27_STABLE
    • Pull Master Branch:
      MDL-45629_master

      Description

      I noticed this when I was viewing the description in the log report which uses '$this->objectid' which is not a valid value, so '' is displayed.

      Note: we can not add an objecttable to this event (well we can't unless we change the logic around), as the event is triggered when the user views the submission page - regardless of whether they have a submission or not.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              markn Mark Nelson
              Reporter:
              markn Mark Nelson
              Peer reviewer:
              Ankit Agarwal
              Integrator:
              Marina Glancy
              Tester:
              Jetha Chan
              Participants:
              Component watchers:
              Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona)
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                14/Jul/14