Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-45652

When restoring a backup, if no category or course is selected the page reloads with no error message

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.6.3, 2.7
    • Fix Version/s: 2.6.4, 2.7.1
    • Component/s: Backup
    • Labels:
    • Testing Instructions:
      Hide
      1. Ensure you have multiple courses on your test site.
      2. Enter a course.
      3. Click on 'Backup' under 'Course administration'.
      4. Backup the course.
      5. Click on 'Restore' under 'Course administration'.
      6. Choose the backup you just created to restore.
      7. Get to the 'Destination' stage in the restore process (second stage).
      8. Select 'Restore as a new course' but do not select a category.
      9. Submit.
      10. Ensure you are taken back to the form with the 'Select a category' field highlighted as required.
      11. This time under 'Restore into an existing course' choose 'Merge the backup course into the existing course' but do not select a course'.
      12. Submit.
      13. Ensure you are taken back to the form with the 'Select a course' field highlighted as required.
      14. Now restore the course using the three options provided and ensure it works as expected.
      Show
      Ensure you have multiple courses on your test site. Enter a course. Click on 'Backup' under 'Course administration'. Backup the course. Click on 'Restore' under 'Course administration'. Choose the backup you just created to restore. Get to the 'Destination' stage in the restore process (second stage). Select 'Restore as a new course' but do not select a category. Submit. Ensure you are taken back to the form with the 'Select a category' field highlighted as required. This time under 'Restore into an existing course' choose 'Merge the backup course into the existing course' but do not select a course'. Submit. Ensure you are taken back to the form with the 'Select a course' field highlighted as required. Now restore the course using the three options provided and ensure it works as expected.
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_26_STABLE, MOODLE_27_STABLE
    • Fixed Branches:
      MOODLE_26_STABLE, MOODLE_27_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-45652_master
    • Pull Master Diff URL:
    • Story Points:
      8
    • Sprint:
      BACKEND Sprint 13

      Description

      If you restore a backup and at the Destination stage, you choose to create a new course but do not select a category, the page reloads upon pressing the Continue button.
      There needs to be an error message stating why the page reloads, as currently it's not obvious that you've forgotten to select which course.

      Steps to replicate:

      1. Log in as admin/course creator
      2. Click 'Restore' in Site Administration
      3. Upload a backup
      4. At destination stage, Click the Continue button under "Restore as a new course" without selecting a category.

      Expected Result: The page would reload and generate an error telling you that you must select a category to restore to

      Actual result: The page reloads with no indication as to why it reloaded.

        Attachments

          Activity

            People

            Assignee:
            markn Mark Nelson
            Reporter:
            danbennett Dan Bennett
            Peer reviewer:
            Frédéric Massart Frédéric Massart
            Integrator:
            Damyon Wiese Damyon Wiese
            Tester:
            Simey Lameze Simey Lameze
            Participants:
            Component watchers:
            Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              14/Jul/14