Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-36558 Add element library to moodle
  3. MDL-45655

Convert confirm dialogues to use the confirm renderer

    XMLWordPrintable

Details

    • Sub-task
    • Status: Open
    • Minor
    • Resolution: Unresolved
    • 2.6.3
    • FRONTEND
    • HTML and CSS
    • MOODLE_26_STABLE

    Description

      There's about 40 instances of dialogues that hand-code the equivalent of the "confirm" renderer, i.e. producing a div#notice.generalbox.box with at least one button (often simply "continue").

      Some of them vary the HTML slightly, which makes it hard to style them (e.g. putting the buttons outside of the div#notice , rather than inside it), and obviously any changes or improvments made to the renderer will not affect these bits of duplicated code.

      You can find most of them with this command:

      $ git grep -e box --and -e "'notice'"

      Attachments

        Issue Links

          Activity

            People

              Unassigned Unassigned
              bawjaws David Scotson
              Amy Groshek, David Scotson, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated: