[MDL-45679] Essay question type grading page does not mark already graded and sent essays - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: 2.6.3, 2.7, 2.7.3, 2.8.1
Fix Version/s: 2.7.4, 2.8.2
Component/s: Lesson
Labels:
- ci
- patch
- triaged

Affected Branches:
MOODLE_26_STABLE, MOODLE_27_STABLE, MOODLE_28_STABLE
Fixed Branches:
MOODLE_27_STABLE, MOODLE_28_STABLE
Pull from Repository:
git://github.com/jmvedrine/moodle.git
Pull Master Branch:
~~MDL-45679~~
Pull Master Diff URL:
https://github.com/jmvedrine/moodle/compare/master...MDL-45679
Workaround:

Hide

Click on each attempt to see if it is graded or not
Poor teacher !!

Show
Click on each attempt to see if it is graded or not Poor teacher !!
Testing Instructions:
Hide

As a teacher create a lesson with some essay questions. Allow re-takes

As student A attempts the lesson several times giving some answers to essay questions

As student B do the same thing

As a teacher click on the "Grade essays tab and verify all links to student attempts are displayed on a red background

Grade some of these attempts and verify the background of these attempts change to yellow, and the other attempts are unmodified

Click on the "Email graded Essay" link on the last column for student A and verify the background for the graded essays of student A change to green, other background should stay unchanged.

Grade some more attempts for student A and student B

Click on the "Email ALL graded essay" link on the last line and verify that all graded essays are now displayed on a green background
Show
As a teacher create a lesson with some essay questions. Allow re-takes As student A attempts the lesson several times giving some answers to essay questions As student B do the same thing As a teacher click on the "Grade essays tab and verify all links to student attempts are displayed on a red background Grade some of these attempts and verify the background of these attempts change to yellow, and the other attempts are unmodified Click on the "Email graded Essay" link on the last column for student A and verify the background for the graded essays of student A change to green, other background should stay unchanged. Grade some more attempts for student A and student B Click on the "Email ALL graded essay" link on the last line and verify that all graded essays are now displayed on a green background

Description

There is an issue in the mod/lesson/essay.php(line 357):

// Different colors for all the states of an essay (graded, if sent, not graded)

if (!$essayinfo->graded) {

    $attributes['class'] = "graded";

} elseif (!$essayinfo->sent) {

    $attributes['class'] = "sent";

} else {

    $attributes['class'] = "ungraded";

Code above always marks essays as ungraded. Should be changed to:

// Different colors for all the states of an essay (graded, if sent, not graded)

if (!$essayinfo->graded) {

    $attributes['class'] = "ungraded";

} elseif (!$essayinfo->sent) {

    $attributes['class'] = "graded";

} else {

    $attributes['class'] = "sent";

There is also issue with default theme. By default it has no CSS classes "ungraded", "graded", "sent". Current workaround: add CSS from administration panel.

Attachments

Issue Links

will help resolve

MDL-45097 Showing which essays have already been graded in Lessons

Closed

Activity

People

Assignee:: Jean-Michel Vedrine

Reporter:: NeiL Eldarson

Peer reviewer:: David Monllaó

Integrator:: Dan Poltawski

Tester:: Marina Glancy

Participants:: CiBoT, Dan Poltawski, David Monllaó, Eloy Lafuente (stronk7), Jean-Michel Vedrine, Marina Glancy, Michael de Raadt, NeiL Eldarson

Component watchers:: Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Sujith Haridasan

Votes:: 1 Vote for this issue

Watchers:: 6 Start watching this issue

Dates

Created:: 24/May/14 2:11 AM

Updated:: 12/Dec/14 3:47 AM

Resolved:: 12/Dec/14 3:47 AM

Fix Release Date:: 12/Jan/15