Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-45679

Essay question type grading page does not mark already graded and sent essays

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 2.6.3, 2.7, 2.7.3, 2.8.1
    • 2.7.4, 2.8.2
    • Lesson
    • MOODLE_26_STABLE, MOODLE_27_STABLE, MOODLE_28_STABLE
    • MOODLE_27_STABLE, MOODLE_28_STABLE
    • Hide

      Click on each attempt to see if it is graded or not
      Poor teacher !!

      Show
      Click on each attempt to see if it is graded or not Poor teacher !!
    • Hide
      • As a teacher create a lesson with some essay questions. Allow re-takes
      • As student A attempts the lesson several times giving some answers to essay questions
      • As student B do the same thing
      • As a teacher click on the "Grade essays tab and verify all links to student attempts are displayed on a red background
      • Grade some of these attempts and verify the background of these attempts change to yellow, and the other attempts are unmodified
      • Click on the "Email graded Essay" link on the last column for student A and verify the background for the graded essays of student A change to green, other background should stay unchanged.
      • Grade some more attempts for student A and student B
      • Click on the "Email ALL graded essay" link on the last line and verify that all graded essays are now displayed on a green background
      Show
      As a teacher create a lesson with some essay questions. Allow re-takes As student A attempts the lesson several times giving some answers to essay questions As student B do the same thing As a teacher click on the "Grade essays tab and verify all links to student attempts are displayed on a red background Grade some of these attempts and verify the background of these attempts change to yellow, and the other attempts are unmodified Click on the "Email graded Essay" link on the last column for student A and verify the background for the graded essays of student A change to green, other background should stay unchanged. Grade some more attempts for student A and student B Click on the "Email ALL graded essay" link on the last line and verify that all graded essays are now displayed on a green background

    Description

      There is an issue in the mod/lesson/essay.php(line 357):

      // Different colors for all the states of an essay (graded, if sent, not graded)
      if (!$essayinfo->graded) {
          $attributes['class'] = "graded";
      } elseif (!$essayinfo->sent) {
          $attributes['class'] = "sent";
      } else {
          $attributes['class'] = "ungraded";
      }
      

      Code above always marks essays as ungraded. Should be changed to:

      // Different colors for all the states of an essay (graded, if sent, not graded)
      if (!$essayinfo->graded) {
          $attributes['class'] = "ungraded";
      } elseif (!$essayinfo->sent) {
          $attributes['class'] = "graded";
      } else {
          $attributes['class'] = "sent";
      }
      

      There is also issue with default theme. By default it has no CSS classes "ungraded", "graded", "sent". Current workaround: add CSS from administration panel.

      Attachments

        Issue Links

          Activity

            People

              jmvedrine Jean-Michel Vedrine
              everard NeiL Eldarson
              David Monllaó David Monllaó
              Dan Poltawski Dan Poltawski
              Marina Glancy Marina Glancy
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Sujith Haridasan
              Votes:
              1 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                12/Jan/15