Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-45759

Incorrect wording on confirm dialogues in Moodle 2.7

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. Create a new quiz which has a time limit enabled and set
      2. Add a basic question (anyhting will do)
      3. As a student, go to the quiz
      4. Click the "Attempt quiz now" button
        • Confirm that the buttons are marked "Start attempt" and "Cancel"
      5. Open your console, and run:

        M.util.show_confirm_dialog(Y, {
        cancellabel: "No - 45759",
        continuelabel: "Yes - 45759",
        message: "Question - 45759"
        });
        

        • Confirm that the texts are the ones you supplied
      6. Close the dialogue
      7. Run the following to open a generic confirmation:

        var dialogue = new M.core.confirm({});
        

      8. Now modify each of the texts and confirm that they update in the UI:

        dialogue.set('noLabel', "No - 45759");
        dialogue.set('yesLabel', "Yes - 45759");
        

      Test 2:

      Run behat with --name "Add and configure small quiz and perform an attempt as a student with Javascript enabled"

      Show
      Create a new quiz which has a time limit enabled and set Add a basic question (anyhting will do) As a student, go to the quiz Click the "Attempt quiz now" button Confirm that the buttons are marked "Start attempt" and "Cancel" Open your console, and run: M.util.show_confirm_dialog(Y, { cancellabel: "No - 45759", continuelabel: "Yes - 45759", message: "Question - 45759" }); Confirm that the texts are the ones you supplied Close the dialogue Run the following to open a generic confirmation: var dialogue = new M.core.confirm({}); Now modify each of the texts and confirm that they update in the UI : dialogue.set('noLabel', "No - 45759"); dialogue.set('yesLabel', "Yes - 45759"); Test 2: Run behat with --name "Add and configure small quiz and perform an attempt as a student with Javascript enabled"
    • Affected Branches:
      MOODLE_27_STABLE
    • Fixed Branches:
      MOODLE_27_STABLE
    • Pull Master Branch:
      MDL-45759-master

      Description

      When a user starts a time quiz, they should see a confirm dialogue with two buttons, Cancel and Start attempt. See, for eample start_attempt_button in mod/quiz/renderer.php and start_attempt_action in mod/quiz/module.js.

      However, the button currently has two buttons Yes and Cancel, and Yes is not translatable. 'Yes' is less good usability that 'Start attemtp'.

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                8 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  8/Sep/14