Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-45772

Some forms with passwords and usernames get populated by the browser, which is not desired

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      On all browsers

      1. Log in to your moodle course as an admin
      2. In the browser, select to save your password
      3. Create a course
      4. On that creation screen, or course edit screen, check that your username does not appear in the id field, and your password does not appear in the enrolment key
      5. Save the form
      6. Use firebug (or the chrome inspecter or the equivalent in the current browser) to view the "form data" and make sure your password wasn't passed
        1. Open the inspector
        2. Click the network tab
        3. Select the request at the top (you may need to scroll)
        4. Select the headers tab
        5. Scroll to "Form data"
      7. Search admin settings for "password"
      8. Ensure that no password fields are automatically filled and it has no additional space at the top of the form when compared with stable
      9. Go to quiz admin settings
      10. Ensure the password field is not automatically filled and it has no additional space at the top of the form when compared with stable
      11. Try logging in
      12. Ensure that your password is autofilled as expected
      13. On your database, run this sql: DELETE FROM mdl_config where name = 'smtppass' OR name = 'smtpuser'
      14. Go to Site administration > Notifications and click check for updates
      15. Make sure the username and password are not filled in automatically and it has no additional space at the top of the form, compared to stable
      Show
      On all browsers Log in to your moodle course as an admin In the browser, select to save your password Create a course On that creation screen, or course edit screen, check that your username does not appear in the id field, and your password does not appear in the enrolment key Save the form Use firebug (or the chrome inspecter or the equivalent in the current browser) to view the "form data" and make sure your password wasn't passed Open the inspector Click the network tab Select the request at the top (you may need to scroll) Select the headers tab Scroll to "Form data" Search admin settings for "password" Ensure that no password fields are automatically filled and it has no additional space at the top of the form when compared with stable Go to quiz admin settings Ensure the password field is not automatically filled and it has no additional space at the top of the form when compared with stable Try logging in Ensure that your password is autofilled as expected On your database, run this sql: DELETE FROM mdl_config where name = 'smtppass' OR name = 'smtpuser' Go to Site administration > Notifications and click check for updates Make sure the username and password are not filled in automatically and it has no additional space at the top of the form, compared to stable
    • Affected Branches:
      MOODLE_27_STABLE, MOODLE_28_STABLE, MOODLE_29_STABLE
    • Fixed Branches:
      MOODLE_28_STABLE, MOODLE_29_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-45772-master-4
    • Story Points:
      20
    • Sprint:
      BACKEND Sprint 14, Team Beards Sprint 9

      Description

      When i tried to create a new group in a course, my username and password were pre-populated in the group id and the password for the group.
      step 1: create group in a course
      step 2: look at the pre-populated fields (group id and password) they are the same as my LDAP username and password.

      I had a colleague log in on my machine with his credentials and my details were pre-populated.

      When my colleague logged in on his machine his details were pre-populated

      My thoughts are if they are pre-populating here then were else are they populating.

      I have cleared cache. logged out then back in again

      Regards
      Brendan

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                12 Vote for this issue
                Watchers:
                40 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  14/Sep/15