Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-45841

It is hard to find unread posts in blog-style forums

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.5.5, 2.6.3, 2.7
    • Fix Version/s: 2.8.8, 2.9.2
    • Component/s: Forum
    • Labels:

      Description

      I am experiencing this on https://moodle.org/mod/forum/view.php?id=8149

      Steps to reproduce (you will need to switch roles a lot. I suggest logging in as Student and Teacher in two different browsers):

      1. As student verify that you have unread forum post tracking enabled.
      2. As teacher, create a blog-style forum in a course.
      3. Start a discussion there.
      4. As student, go an look at the forum. (You can see that there is a new unread thread.)
      5. As teacher, go and reply to the discussion you started.
      6. As student, go back to the course page. You can see the post is unread.
      7. Click into the forum. Note you cannot see which thread has the unread posts in it. (Well, in this case there is only one thread, but if there are many threads, it is a problem.)
      8. Click Discuss this topic. Now you can see which post is unread.

      The best way I can think of to fix this, is to change the '(1 reply so far)' mesage in the UI to '(1 reply so far, 1 unread)', with the 1 unread bit styled like the '1 unread post' message on the course page.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

              Hide
              mina Nicolas Martignoni added a comment -

              Any progress? This is badly needed, e.g. in "Plugins traffic Forum" on Moodle in English course of moodle.org.

              Show
              mina Nicolas Martignoni added a comment - Any progress? This is badly needed, e.g. in "Plugins traffic Forum" on Moodle in English course of moodle.org.
              Hide
              timhunt Tim Hunt added a comment -

              I think this is enough of a usability bug, that it is worth back-porting, but others might disagree.

              Show
              timhunt Tim Hunt added a comment - I think this is enough of a usability bug, that it is worth back-porting, but others might disagree.
              Hide
              cibot CiBoT added a comment -

              Code verified against automated checks.

              Checked MDL-45841 using repository: git://github.com/timhunt/moodle.git

              More information about this report

              Show
              cibot CiBoT added a comment - Code verified against automated checks. Checked MDL-45841 using repository: git://github.com/timhunt/moodle.git MOODLE_28_STABLE (0 errors / 0 warnings) [branch: MDL-45841_28 | CI Job ] MOODLE_29_STABLE (0 errors / 0 warnings) [branch: MDL-45841_29 | CI Job ] master (0 errors / 0 warnings) [branch: MDL-45841 | CI Job ] More information about this report
              Hide
              mudrd8mz David Mudrák added a comment -

              Thanks Tim for the patch. My +1 for the solution and I also think it is safe to go to stable branches as the actual UI change is very tiny.

              There is only one thing I would suggest to consider yet. I'd like to see a text separator between the two messages so that it would read like

              2 replies so far / 2 unread posts

              instead of the current

              2 replies so far 2 unread posts

              without relying on the actual styling of the "unread" CSS class.

              Show
              mudrd8mz David Mudrák added a comment - Thanks Tim for the patch. My +1 for the solution and I also think it is safe to go to stable branches as the actual UI change is very tiny. There is only one thing I would suggest to consider yet. I'd like to see a text separator between the two messages so that it would read like 2 replies so far / 2 unread posts instead of the current 2 replies so far 2 unread posts without relying on the actual styling of the "unread" CSS class.
              Hide
              mudrd8mz David Mudrák added a comment -

              Something like this

              diff --git a/mod/forum/lib.php b/mod/forum/lib.php
              index 71aade9..5f4d874 100644
              --- a/mod/forum/lib.php
              +++ b/mod/forum/lib.php
              @@ -3506,7 +3506,7 @@ function forum_print_post($post, $discussion, $forum, &$cm, $course, $ownpost=fa
                           $replystring = get_string('repliesmany', 'forum', $post->replies);
                       }
                       if (!empty($discussion->unread) && $discussion->unread !== '-') {
              -            $replystring .= ' <span class="unread">';
              +            $replystring .= ' <span class="sep">/</span> <span class="unread">';
                           if ($discussion->unread == 1) {
                               $replystring .= get_string('unreadpostsone', 'forum');
                           } else {
              
              

              Show
              mudrd8mz David Mudrák added a comment - Something like this diff --git a/mod/forum/lib.php b/mod/forum/lib.php index 71aade9..5f4d874 100644 --- a/mod/forum/lib.php +++ b/mod/forum/lib.php @@ -3506,7 +3506,7 @@ function forum_print_post($post, $discussion, $forum, &$cm, $course, $ownpost=fa $replystring = get_string('repliesmany', 'forum', $post->replies); } if (!empty($discussion->unread) && $discussion->unread !== '-') { - $replystring .= ' <span class="unread">'; + $replystring .= ' <span class="sep">/</span> <span class="unread">'; if ($discussion->unread == 1) { $replystring .= get_string('unreadpostsone', 'forum'); } else {
              Hide
              timhunt Tim Hunt added a comment -

              +1 for your extra change. I will amend my commits when I get home tonight.

              Show
              timhunt Tim Hunt added a comment - +1 for your extra change. I will amend my commits when I get home tonight.
              Hide
              timhunt Tim Hunt added a comment -

              Commits amended. Submitting for integration.

              Show
              timhunt Tim Hunt added a comment - Commits amended. Submitting for integration.
              Hide
              cibot CiBoT added a comment -

              Code verified against automated checks.

              Checked MDL-45841 using repository: git://github.com/timhunt/moodle.git

              More information about this report

              Show
              cibot CiBoT added a comment - Code verified against automated checks. Checked MDL-45841 using repository: git://github.com/timhunt/moodle.git MOODLE_28_STABLE (0 errors / 0 warnings) [branch: MDL-45841_28 | CI Job ] MOODLE_29_STABLE (0 errors / 0 warnings) [branch: MDL-45841_29 | CI Job ] master (0 errors / 0 warnings) [branch: MDL-45841 | CI Job ] More information about this report
              Hide
              poltawski Dan Poltawski added a comment -

              The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.
              TIA and ciao

              Show
              poltawski Dan Poltawski added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
              Hide
              cibot CiBoT added a comment -

              Moving this issue to current integration cycle, will be reviewed soon. Thanks for the hard work!

              Show
              cibot CiBoT added a comment - Moving this issue to current integration cycle, will be reviewed soon. Thanks for the hard work!
              Hide
              cibot CiBoT added a comment -

              Code verified against automated checks.

              Checked MDL-45841 using repository: git://github.com/timhunt/moodle.git

              More information about this report

              Show
              cibot CiBoT added a comment - Code verified against automated checks. Checked MDL-45841 using repository: git://github.com/timhunt/moodle.git MOODLE_28_STABLE (0 errors / 0 warnings) [branch: MDL-45841_28 | CI Job ] MOODLE_29_STABLE (0 errors / 0 warnings) [branch: MDL-45841_29 | CI Job ] master (0 errors / 0 warnings) [branch: MDL-45841 | CI Job ] More information about this report
              Hide
              poltawski Dan Poltawski added a comment -

              Thanks, integrated to master, 29 and 28

              Show
              poltawski Dan Poltawski added a comment - Thanks, integrated to master, 29 and 28
              Hide
              ryanwyllie Ryan Wyllie added a comment -

              Thanks for the patch, Tim. I've tested the changes on master, 29 and 28 and all looks good. Re: 6: I'm imagining it and the future looks glorious.

              Testing passed.

              Show
              ryanwyllie Ryan Wyllie added a comment - Thanks for the patch, Tim. I've tested the changes on master, 29 and 28 and all looks good. Re: 6: I'm imagining it and the future looks glorious. Testing passed.
              Hide
              poltawski Dan Poltawski added a comment -

              Thanks for your contributions! This change is now available from the main moodle.git repository and will shortly be available on download.moodle.org.

              The best error message is the one that never shows up.
              --Thomas Fuchs

              Show
              poltawski Dan Poltawski added a comment - Thanks for your contributions! This change is now available from the main moodle.git repository and will shortly be available on download.moodle.org. The best error message is the one that never shows up. --Thomas Fuchs

                People

                • Votes:
                  4 Vote for this issue
                  Watchers:
                  4 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    14/Sep/15