Details
-
Improvement
-
Status: Closed
-
Minor
-
Resolution: Deferred
-
2.7, 2.7.3, 2.8.1, 2.9
-
None
-
MOODLE_27_STABLE, MOODLE_28_STABLE, MOODLE_29_STABLE
-
MDL-45865-master
Description
I was doing some light reading the other day and found the following comment in lib/weblib.php
// When we move to PHP 5.4 as a minimum version, change ENT_QUOTES on the
|
// next line to ENT_QUOTES | ENT_HTML5 | ENT_SUBSTITUTE, and remove the
|
// 'UTF-8' argument. Both bring a speed-increase.
|
return preg_replace('/&#(\d+|x[0-9a-f]+);/i', '&#$1;', htmlspecialchars($var, ENT_QUOTES, 'UTF-8'));
|
As of Moodle 2.7 PHP 5.4 is required so this change should be made to 2.7 and 2.8dev. I don't know what it means, but hope somebody remembers it.
See https://github.com/moodle/moodle/blob/master/lib/weblib.php#L99
Attachments
Issue Links
- has a non-specific relationship to
-
MDL-39378 Fix s() hex entity handling, and improve performance
-
- Closed
-