[MDL-45887] Fix coding guideline violations in mod_scorm - Moodle Tracker

XML

Word

Printable

Affected Branches:
MOODLE_27_STABLE
Fixed Branches:
MOODLE_28_STABLE
Pull from Repository:
https://github.com/danmarsden/moodle.git
Pull Master Branch:
~~MDL-45887~~
Pull Master Diff URL:
https://github.com/danmarsden/moodle/compare/MDL-45887
Testing Instructions:

Hide

Re-run a selection of the QA tests for the scorm module:

https://tracker.moodle.org/browse/MDLQA-6752
https://tracker.moodle.org/browse/MDLQA-6755
https://tracker.moodle.org/browse/MDLQA-6758

Show
Re-run a selection of the QA tests for the scorm module: https://tracker.moodle.org/browse/MDLQA-6752 https://tracker.moodle.org/browse/MDLQA-6755 https://tracker.moodle.org/browse/MDLQA-6758

mod_scorm has lots of code that violates the standards mentioned in the coding guideline. http://docs.moodle.org/dev/Coding_style. Fix all the files in /mod/scorm that violates the standard. Use the checker plugin for finding the violations. https://moodle.org/plugins/view.php?plugin=local_codechecker

blocks

MDL-46669 mod_scorm: GetValue adds quotes to string values, in 1.3 copy only

MDL-46469 Support autoloaded namespaced classnames for scorm report plugins

has been marked as being related by

MDL-46738 Fix PHPDoc in SCORM

is blocked by

MDL-46397 Progress through a SCORM activity is not tracked

MDL-46760 SCORM and New Window does not work when preview disabled.

MDL-35870 improving caching of SCORM JS and improve general structure.

(1 is blocked by)

Participants:: Ankit Agarwal, CiBoT, Damyon Wiese, Dan Marsden, Eloy Lafuente (stronk7), Marina Glancy, Michael de Raadt, vignesh p

Component watchers:: Dan Marsden, Matteo Scaramuccia, Ilya Tregubov, Kevin Percy, Mathew May, Mihail Geshoski, Shamim Rezaie