-
Improvement
-
Resolution: Fixed
-
Minor
-
2.8
-
MOODLE_28_STABLE
-
MOODLE_28_STABLE
-
MDL-45893-master-v3 -
-
100
-
FRONTEND Sprint 14
Adding a User Menu, in the bootstrapbase themes; refer to the specification to know what it should contain, and how to implement it.
The general approach here is to refactor the existing navbar's capabilities, allowing it to support multiple dropdowns without adversely affecting existing DOM structure (which would necessitate every theme re-targeting its styles).
Update 10/06/2014: The user menu is being rendered fine, but the current solution doesn't quite encapsulate everything that'll need to happen with the navbar; in particular, page_heading_menu() stuff isn't handled by this solution as it doesn't really make sense for that stuff to live in a dropdown.
Update 24/06/2014: Okay, this turned out to be huge.
- The new user_menu renderable is an extension of the custom_menu renderable, constructed with references to a user, a course, a page and an array of flags (at present, the only thing that makes sense to set a priori is guest, a boolean flag).
- Basing the new renderable on the custom_menu allows for it to be easily displayed in Base-based themes as well.
- A minor bug in custom_menu's YUI3 dropdown code was fixed: in brief, the logic was looking for a dropdown attribute on the node that was clicked (e.target) instead of the node that the event was actually wired to (e.currentTarget).
- custom_menu renderables have been extended by way of
MDL-46022and have also gained the ability to assign CSS suffix flags to {{custom_menu_item}}s - which is necessary for us to avoid having to hardcode icons into the renderer PHP. - In order to support multiple collapsible menus, it was necessary to create an entire bootstrap_navbar renderable which renders the body > header element and renders out a collection of menus. Bootstrap javascript has been patched to allow for multiple navbar items.
- Responsive styles have been provided.
- blocks
-
MDL-46376 user_menu API to enqueue menu items
- Closed
-
MDL-46377 user_menu API to reorder + selectively disable contents of button
- Closed
- caused a regression
-
MDL-47819 User menu should not appear in popups
- Closed
-
MDL-47457 We need a log in icon for the user menu.
- Closed
-
MDL-54559 Usermenu margin expands navbar
- Closed
-
MDL-57182 $CFG->displayloginfailures not rendering notice in page footer
- Closed
- has a non-specific relationship to
-
MDLSITE-3666 Make the user menu show on learn.moodle.net
- Resolved
- has been marked as being related by
-
MDL-49471 user_menu does not validate access to items - if badges/messages are enabled, if user has capabilities, etc.
- Closed
-
MDL-44512 Custom menu submenu arrows appear on the right on RTL languages
- Closed
-
MDL-47559 Add customusermenu theme setting so admins can add items to the new user menu
- Closed
-
MDL-46114 Theme layout elements renderer from theme_easy
- Closed
- is blocked by
-
MDL-46523 Add body class when logged in as other role
- Closed
- Testing discovered
-
MDL-47576 Improve styling of the new user menu
- Closed
- will be (partly) resolved by
-
MDL-46920 Data-target does nothing
- Closed
-
MDL-47340 action_menu: selector, RTL, consistency fixes
- Closed
-
MDL-46022 Add ability to create dividers in custom_menu
- Closed