Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-45933

Saving all quick grading changes for no users results in coding error: moodle_database::get_in_or_equal() does not accept empty arrays

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Open an assignment
      Go to the grading table
      Enable quick grading (bleh)
      Change the filter so no users are shown in the table (e.g. submitted when there are no submissions)
      Click "Save all quick grading changes"
      Verify the next page just gives a (semi) useful message and no fatal error

      Show
      Open an assignment Go to the grading table Enable quick grading (bleh) Change the filter so no users are shown in the table (e.g. submitted when there are no submissions) Click "Save all quick grading changes" Verify the next page just gives a (semi) useful message and no fatal error
    • Affected Branches:
      MOODLE_26_STABLE, MOODLE_27_STABLE
    • Fixed Branches:
      MOODLE_26_STABLE, MOODLE_27_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-45933-master

      Description

      In a course with no students, clicking "Save all quick grading changes" for an assignment results in a coding error:

      "Coding error detected, it must be fixed by a programmer: moodle_database::get_in_or_equal() does not accept empty arrays"

      Steps to reproduce:

      1. Create a course but do not enroll any students in the course.
      2. Create an assignment.
      3. Open assignment.
      4. Click View/Grade All Submissions.
      5. Make sure quick grading is on and note that "Save all quick grading changes" button displays.
      6. Click "Save all quick grading changes" button.

      Expected result: Either the save changes button shouldn't display at all, or if it does and someone clicks it, a friendly message should be received to the effect of "There are no submissions to save."

      Actual result: Coding error.

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  14/Jul/14