[MDL-45945] MS-SQL Collation in Temp Tables (as seen in LDAP Auth Import) - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: 2.6.3, 2.7
Fix Version/s: 2.7.1
Component/s: Authentication, Database SQL/XMLDB
Labels:
- Totara
- ci
- triaged

Affected Branches:
MOODLE_26_STABLE, MOODLE_27_STABLE
Fixed Branches:
MOODLE_27_STABLE
Pull from Repository:
https://github.com/skodak/moodle.git
Pull Master Branch:
wip_~~MDL-45945~~_m28_mssqlcol
Pull Master Diff URL:
https://github.com/skodak/moodle/compare/master...wip_MDL-45945_m28_mssqlcol
Testing Instructions:

Hide

1/ execute unit tests for MSSQL (both drivers are using the same code, you can pick on driver one)

Show
1/ execute unit tests for MSSQL (both drivers are using the same code, you can pick on driver one)

Description

When running the LDAP Sync an error message is displayed stating that a collation conflict is causing a compare issue and no records are returned.

This seems to be happening because the collation settings on the MS SQL 2008 R2 Master DB are different from the Collation settings on the Moodle database. When a temp table is created (as it apparently is in the LDAP sync operation) it is created with the collation of the TempDB, by default, which is inherited from the MasterDB.

The creation query of the temp table should be modified to contain 'COLLATE database_default' so that it inherits the collation of the Moodle database rather than the instance default.

The error message is posted at:
https://moodle.org/mod/forum/discuss.php?d=261836

Attachments

Issue Links

caused a regression

MDL-46327 Oracle phpunit tests stopping after exception

Closed

Activity

People

Assignee:: Petr Skoda

Reporter:: Ryan Hanisco

Peer reviewer:: Dan Poltawski

Integrator:: Eloy Lafuente (stronk7)

Tester:: Eloy Lafuente (stronk7)

Participants:: CiBoT, Damyon Wiese, Dan Poltawski, Eloy Lafuente (stronk7), Petr Skoda, Ryan Hanisco

Component watchers:: David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo, David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo

Votes:: 0 Vote for this issue

Watchers:: 2 Start watching this issue

Dates

Created:: 11/Jun/14 1:48 AM

Updated:: 31/Jul/14 11:14 PM

Resolved:: 11/Jul/14 10:51 AM

Fix Release Date:: 14/Jul/14