Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-45978

missing param "id" in report/log/index.php

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.7, 2.8
    • Fix Version/s: 2.7.1
    • Component/s: Logging, Reports
    • Labels:
    • Testing Instructions:
      Hide
      1. You need an installation with one or more courses on it.
      2. You need a count of log entries for one of these courses so that these entries dosen't fit on a single page and we get a navigation bar for the result table.
      3. Go to "Site administration / Reports / Logs".
      4. Choose in the first select box the course with the wanted log entries. Make a note of the course you chose.
      5. Click on "Get these logs".
      6. Look at the link "Next" in the navigation bar. In the link URL there should be the parameter "id". Click on "next".
      7. Check that you are shown page 2 and that you are still only seeing log entries for your selected course.
      Show
      You need an installation with one or more courses on it. You need a count of log entries for one of these courses so that these entries dosen't fit on a single page and we get a navigation bar for the result table. Go to "Site administration / Reports / Logs". Choose in the first select box the course with the wanted log entries. Make a note of the course you chose. Click on "Get these logs". Look at the link "Next" in the navigation bar. In the link URL there should be the parameter "id". Click on "next". Check that you are shown page 2 and that you are still only seeing log entries for your selected course.
    • Affected Branches:
      MOODLE_27_STABLE, MOODLE_28_STABLE
    • Fixed Branches:
      MOODLE_27_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-45978_master

      Description

      If you watch the log entries on the page "Site administration / Reports / Logs" and you choose a course in first select box (parameter: id) after clicking on "Get these logs" the table looks fine but the page navigation is rendered without the param "id". So if you on "Next" the logs of the whole site is shown.
      The fix is easy. Add the following lines in index.php on line 47:

      if ($id) {
          $params['id'] = $id;
      }
      

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              grabs Andreas Grabs
              Reporter:
              grabs Andreas Grabs
              Peer reviewer:
              Andrew Davis
              Integrator:
              Eloy Lafuente (stronk7)
              Tester:
              Adrian Greeve
              Participants:
              Component watchers:
              Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                14/Jul/14