[MDL-46022] Add ability to create dividers in custom_menu - Moodle Tracker

XML

Word

Printable

Details

Type: Improvement
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 2.8
Fix Version/s: 2.8
Component/s: Navigation
Labels:
- ci
- triaged
- ui_change

Affected Branches:
MOODLE_28_STABLE
Fixed Branches:
MOODLE_28_STABLE
Epic Link:
Navigation overhaul: User context
Pull from Repository:
git://github.com/jethac/moodle.git
Pull Master Branch:
~~MDL-46022~~-master
Pull Master Diff URL:
https://github.com/jethac/moodle/compare/337075d...MDL-46022-master
Testing Instructions:
Hide

On master:

Create a custom_menu with multiple options at top level and multiple nested options; make sure you're using the new divider functionality, using '####' to create dividers. The example custom_menu is fine for this.

Ensure that no errors or unexpected output is encountered.

On Clean, visually inspect your new custom_menu. Ensure that the dividers appear as you would expect them to.

On Base or Standard, visually inspect your new custom_menu. Ensure, again, that the dividers appear as you would expect them to.

Install an RTL language (e.g. he) and visually inspect the custom_menu again in both Base and Clean.

You may observe broken alignment on Bootstrapbase-based themes when using RTL languages - this is a documented issue, see ~~MDL-44512~~
Show
On master: Create a custom_menu with multiple options at top level and multiple nested options; make sure you're using the new divider functionality, using '####' to create dividers. The example custom_menu is fine for this. Ensure that no errors or unexpected output is encountered. On Clean , visually inspect your new custom_menu. Ensure that the dividers appear as you would expect them to. On Base or Standard , visually inspect your new custom_menu. Ensure, again, that the dividers appear as you would expect them to. Install an RTL language (e.g. he ) and visually inspect the custom_menu again in both Base and Clean . You may observe broken alignment on Bootstrapbase -based themes when using RTL languages - this is a documented issue, see MDL-44512

Story Points:
3
Sprint:
FRONTEND Sprint 12

Description

As ~~MDL-45893~~ is being developed based on custom_menu code, I think it'd be useful to have the ability to create dividers in regular custom_menus too. It is envisioned that you'd be able to specify dividers like this:

Moodle community|http://moodle.org

-Moodle free support|http://moodle.org/support

-####

-Moodle development|http://moodle.org/development

--Moodle Tracker|http://tracker.moodle.org

--Moodle Docs|http://docs.moodle.org

-Moodle News|http://moodle.org/news

####

Moodle company

-Moodle commercial hosting|http://moodle.com/hosting

-Moodle commercial support|http://moodle.com/support

...where a menu item with text of '####' and no URL will be given the class 'divider' at render time. I'd use the '-' character, but that'd conflict with our existing use of that to denote nesting level

Attachments

Issue Links

caused a regression

MDL-50497 Menu divider colors are wrong if 'invert navbar' setting is selected.

Closed

will help resolve

MDL-45893 Developing a User Menu

Closed

Activity

People

Assignee:: Jetha Chan

Reporter:: Jetha Chan

Peer reviewer:: Frédéric Massart

Integrator:: Damyon Wiese

Tester:: Simey Lameze

Participants:: CiBoT, Damyon Wiese, Eloy Lafuente (stronk7), Frédéric Massart, Jetha Chan, Simey Lameze

Component watchers:: David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo

Votes:: 0 Vote for this issue

Watchers:: 4 Start watching this issue

Dates

Created:: 17/Jun/14 9:50 PM

Updated:: 08/Jun/15 5:46 AM

Resolved:: 27/Jun/14 2:39 AM

Fix Release Date:: 10/Nov/14