Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-46022

Add ability to create dividers in custom_menu

    XMLWordPrintable

Details

    • Improvement
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 2.8
    • 2.8
    • Navigation
    • MOODLE_28_STABLE
    • MOODLE_28_STABLE
    • MDL-46022-master
    • Hide

      On master:

      1. Create a custom_menu with multiple options at top level and multiple nested options; make sure you're using the new divider functionality, using '####' to create dividers. The example custom_menu is fine for this.
        • Ensure that no errors or unexpected output is encountered.
      2. On Clean, visually inspect your new custom_menu. Ensure that the dividers appear as you would expect them to.
      3. On Base or Standard, visually inspect your new custom_menu. Ensure, again, that the dividers appear as you would expect them to.
      4. Install an RTL language (e.g. he) and visually inspect the custom_menu again in both Base and Clean.
        • You may observe broken alignment on Bootstrapbase-based themes when using RTL languages - this is a documented issue, see MDL-44512
      Show
      On master: Create a custom_menu with multiple options at top level and multiple nested options; make sure you're using the new divider functionality, using '####' to create dividers. The example custom_menu is fine for this. Ensure that no errors or unexpected output is encountered. On Clean , visually inspect your new custom_menu. Ensure that the dividers appear as you would expect them to. On Base or Standard , visually inspect your new custom_menu. Ensure, again, that the dividers appear as you would expect them to. Install an RTL language (e.g. he ) and visually inspect the custom_menu again in both Base and Clean . You may observe broken alignment on Bootstrapbase -based themes when using RTL languages - this is a documented issue, see MDL-44512
    • 3
    • FRONTEND Sprint 12

    Description

      As MDL-45893 is being developed based on custom_menu code, I think it'd be useful to have the ability to create dividers in regular custom_menus too. It is envisioned that you'd be able to specify dividers like this:

      Moodle community|http://moodle.org
      -Moodle free support|http://moodle.org/support
      -####
      -Moodle development|http://moodle.org/development
      --Moodle Tracker|http://tracker.moodle.org
      --Moodle Docs|http://docs.moodle.org
      -Moodle News|http://moodle.org/news
      ####
      Moodle company
      -Moodle commercial hosting|http://moodle.com/hosting
      -Moodle commercial support|http://moodle.com/support
      

      ...where a menu item with text of '####' and no URL will be given the class 'divider' at render time. I'd use the '-' character, but that'd conflict with our existing use of that to denote nesting level

      Attachments

        Issue Links

          Activity

            People

              jethac Jetha Chan
              jethac Jetha Chan
              Frédéric Massart Frédéric Massart
              Damyon Wiese Damyon Wiese
              Simey Lameze Simey Lameze
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                10/Nov/14