-
Improvement
-
Resolution: Unresolved
-
Major
-
None
-
2.7
We no longer need a non-js fallback. Deleting this file will reduce the amount of code we need to maintain. Also, this is some old YUI code that should go.
Specifically, I think we should:
- Change question/bank/editquestion/classes/output/add_new_question.php and the associated template so it just renders a simple button with some data- attributes. Don't render the HTML of the question chooser into the page.
- Deprecate editquestion_helper::print_choose_qtype_to_add_form etc, and change rendering of the body of the question chooser dialoge to render a tempate. (Does this need to be a fragment, so in order to get the list of qtypes, or should the data go in a data attribut on the button? either might work, need to work out which is best.)
- Replace question/bank/editquestion/yui/src/chooser/js/chooser.js with an ES6 module which makes the Create button and dialogue work.
- Search and destroy any remaining usages of question/bank/editquestion/addquestion.php, then delete that file.
- Work out why \mod_quiz\output\question_chooser exists, and probably get rid of it.
- Make a separate issue for deprecating core\output\chooser and related code, but this is the last use in core.
- has been marked as being related by
-
MDL-81994 Question bank: Why is the 'Create a new question ...' button so slow to initialise?
-
- Open
-
- is blocked by
-
MDL-40457 Question Bank - Allow plugins to add columns to question bank view
-
- Closed
-
-
MDL-46031 We should not use statics for things that should only be output once. It needs to be tracked per-page
-
- Closed
-
- will help resolve
-
MDL-76864 META: Migrate all use of YUI3
-
- Open
-