[MDL-46038] Undefined variable CFG in equella and boxnet - Moodle Tracker

XML

Word

Printable

Affected Branches:
MOODLE_27_STABLE
Fixed Branches:
MOODLE_27_STABLE
Pull from Repository:
git://github.com/marinaglancy/moodle.git
Pull Master Branch:
wip-~~MDL-46038~~-master
Pull Master Diff URL:
https://github.com/marinaglancy/moodle/compare/master...wip-MDL-46038-master
Testing Instructions:
Hide

Proper test (the one that was missed in ~~MDL-40079~~):

Setup equella and boxnet repositories

Add shortcuts to files there in some filearea (i.e. private files)

Wait for one day

Open filearea for editing and make sure there are no warnings

Reasonable test:

Review the code
Show
Proper test (the one that was missed in MDL-40079 ): Setup equella and boxnet repositories Add shortcuts to files there in some filearea (i.e. private files) Wait for one day Open filearea for editing and make sure there are no warnings Reasonable test: Review the code

On editing file area that contained references to Equella I received error:

Notice: Undefined variable: CFG in /home/marina/repositories/master/moodle/repository/equella/lib.php on line 211

Notice: Trying to get property of non-object in /home/marina/repositories/master/moodle/repository/equella/lib.php on line 211

Notice: Trying to get property of non-object in /home/marina/repositories/master/moodle/repository/equella/lib.php on line 219

Notice: Undefined variable: CFG in /home/marina/repositories/master/moodle/repository/equella/lib.php on line 219

I found that this is a regression from ~~MDL-40079~~ and the same error should happen in boxnet

is a regression caused by

MDL-40079 Hardcoded timeout parameter in the repository plugin

Participants:: CiBoT, Damyon Wiese, Eloy Lafuente (stronk7), Marina Glancy, Mark Nelson, Simey Lameze

Component watchers:: David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo