Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-46046

Atto screenreader helper contains dead code

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. Open a page with atto
      2. Enter some images and links in the editor
      3. Open the accessibility/screenreader helper
      4. Make sure clicking on a link selects it in the editor and sets the focus
      5. Make sure clicking on an image selects it and sets the focus on the editor
      6. Make sure closing the dialogue restores the focus on toolbar
      Show
      Open a page with atto Enter some images and links in the editor Open the accessibility/screenreader helper Make sure clicking on a link selects it in the editor and sets the focus Make sure clicking on an image selects it and sets the focus on the editor Make sure closing the dialogue restores the focus on toolbar
    • Affected Branches:
      MOODLE_27_STABLE
    • Fixed Branches:
      MOODLE_27_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-46046-master

      Description

      I noticed that the variable _displayedWarnings, and the onClick delegate are not used at all.

      The variable is a legacy of the accessibility checker, as well as the delegate. Elements clicked on the dialogue are using their own callbacks.

        Attachments

          Activity

            People

            Assignee:
            fred Frédéric Massart
            Reporter:
            fred Frédéric Massart
            Peer reviewer:
            Andrew Nicols
            Integrator:
            Damyon Wiese
            Tester:
            Ankit Agarwal
            Participants:
            Component watchers:
            Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              14/Jul/14