Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-46063

User pictures in Feedback module squeezed to 5px

    XMLWordPrintable

Details

    • MOODLE_26_STABLE, MOODLE_27_STABLE
    • MOODLE_26_STABLE, MOODLE_27_STABLE
    • MDL-46063_master
    • Hide

      In a course with users, go to the the Feedback module.

      • Set "Record user names' to non-anonymous
      • Add a multiple-choice question
      • Answer with a few students
      • As admin in tab "Analysis"
        • expected: colored bars are height: 5px.
      • in tab "Show responses" and "Show non-respondents"
        • expected: user pictures are not height 5px.
      Show
      In a course with users, go to the the Feedback module. Set "Record user names' to non-anonymous Add a multiple-choice question Answer with a few students As admin in tab "Analysis" expected: colored bars are height: 5px. in tab "Show responses" and "Show non-respondents" expected: user pictures are not height 5px.

    Description

      User pictures in Feedback module appear squeezed to 5px height in the "Show responses" and "Show non-respondents" tabs (mod/feedback/show_entries.php, mod/feedback/show_nonrespondents.php).

      This is a side effect of setting mod_feedback analysis bar heights to 5px in "Analysis" tab (mod/feedback/analysis.php), introduced in MDL-42711.

      Here's the CSS-definition in theme/bootstrapbase/less/moodle/modules.less:

      .path-mod-feedback .generalbox div table tbody img {
          height: 5px; // we should remove the bar height specification in core
      }
      

      A more exact definition would help avoid this kind of misinterpretations.
      Something like this would work better:

      #page-mod-feedback-analysis img.feedback_bar_image {
          height: 5px; // we should remove the bar height specification in core
      }
      

      The following lines can probably be removed from mod/feedback/styles.css if they are not required by other themes.

      div img.feedback_bar_image {
          height: 10px;
      }
      

      Attachments

        Issue Links

          Activity

            People

              Unassigned Unassigned
              schach Heiko Schach
              Aparup Banerjee Aparup Banerjee
              Dan Poltawski Dan Poltawski
              Frédéric Massart Frédéric Massart
              Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Laurent David, Raquel Ortega, Sara Arjona (@sarjona), Huong Nguyen, Bas Brands, Mathew May
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                14/Jul/14