Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-46076

Allow javascript-static.js to somewhat work in IE7 [2.6]

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.6.3
    • Fix Version/s: 2.6.4
    • Component/s: JavaScript
    • Labels:
    • Testing Instructions:
      Hide

      1. Visit a course page.
      EXPECTED: There should not be a JavaScript error mentioning 'M.util'.

      (Note: Ideally, this test should be carried out on IE7, but you could just check in some other browser that I didn't break it.)

      Show
      1. Visit a course page. EXPECTED: There should not be a JavaScript error mentioning 'M.util'. (Note: Ideally, this test should be carried out on IE7, but you could just check in some other browser that I didn't break it.)
    • Affected Branches:
      MOODLE_26_STABLE
    • Fixed Branches:
      MOODLE_26_STABLE

      Description

      tl;dr = Please can I remove a superfluous comma in order to make it not completely fall over on IE7?

      I know that Moodle does not support IE7 (or indeed IE8). However we, and probably some other large institutions/companies, still need to in certain cases.

      With custom theme and course format, and turning off some features, Moodle 2.6 can still be made to work in these legacy browsers with only cosmetic problems (like some things being in slightly the wrong place and the page taking about the lifetime of the universe to actually load). However there is a problem with one core JavaScript file - comma at end of array - which we can't work around and which I am submitting for fix here. As this does not cause any problems for other browsers I believe it would be beneficial to include this in Moodle core even though Moodle does not support IE7.

      This issue does not apply to Moodle 2.7+ as the code was changed (from my quick look at the modified code it doesn't have this problem in this place).

      Background just for info: We have a small constituency of work-based learners who are still forced to use IE7 (I think this is NHS people, some idiot worked out it will cost them £100 million to upgrade their browser so they're never going to do it again, even though the thing is riddled with critical security holes - somebody should probably make a virus that upgrades their browser, that would be pretty cool - anyhow). Point being we have contracts and stuff. I don't know how soon we can get out of this, was really hoping we could ditch IE7 (at least) this year, but it doesn't seem too likely... But we need to keep it working for now.

        Attachments

          Activity

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                14/Jul/14