Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-46078

Activity Completion will not process if first submission stays in draft status

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Create a course, make sure to enable copletion tracking in the course
      -Enrol users into the course
      -Add an assignment to the course with the following options
      a) Submission Type - Online Text
      b) Feedback types - Feedback Comments
      c) Submission Settings - Require students click submit button - Yes
      d) Submission Settings - Require that students accept the submission statement - No
      e) Submission Settings - Attempts Reopened - Manually
      f) Submission Settings - Maximum Attempts - Unlimited
      g) Grade - Grade - Nograde
      h) Activity Completion - Student must submit to this activity to complete it - check
      -Add Course Completion settings
      a) General - Course is complete when ALL conditions are met
      b) Condition: Activity Completion - check the assignment created in previous step
      LOGIN AS STUDENT
      -Go to Activity
      -Click Add Submission
      -Enter something in text box
      -Click Save Changes
      -Notice Submission Status = "Draft (not submitted)"
      -Exit activity without doing anything on the "Submission Status" page
      LOGOUt AS STUDENT
      LOGIN AS ADMIN
      -Go to Assignment
      -View/Grade all Submissions
      -Look for submission
      -Go to Edit icon
      -Click "Allow Another Attempt"
      LOGIN AS (SAME) STUDENT
      -Go to the activity
      -Click "Add a new attempt based on previous submission"
      -Enter the submiision
      -Click "Submit Assignment"
      -Click "Continue"
      LOGOUT AS A STUDENT
      LOGIN AS ADMIN
      -Run Cron
      -Go to course
      -Check Course Completion Report
      -Verify the assignment is shown as completed

      Show
      Create a course, make sure to enable copletion tracking in the course -Enrol users into the course -Add an assignment to the course with the following options a) Submission Type - Online Text b) Feedback types - Feedback Comments c) Submission Settings - Require students click submit button - Yes d) Submission Settings - Require that students accept the submission statement - No e) Submission Settings - Attempts Reopened - Manually f) Submission Settings - Maximum Attempts - Unlimited g) Grade - Grade - Nograde h) Activity Completion - Student must submit to this activity to complete it - check -Add Course Completion settings a) General - Course is complete when ALL conditions are met b) Condition: Activity Completion - check the assignment created in previous step LOGIN AS STUDENT -Go to Activity -Click Add Submission -Enter something in text box -Click Save Changes -Notice Submission Status = "Draft (not submitted)" -Exit activity without doing anything on the "Submission Status" page LOGOUt AS STUDENT LOGIN AS ADMIN -Go to Assignment -View/Grade all Submissions -Look for submission -Go to Edit icon -Click "Allow Another Attempt" LOGIN AS (SAME) STUDENT -Go to the activity -Click "Add a new attempt based on previous submission" -Enter the submiision -Click "Submit Assignment" -Click "Continue" LOGOUT AS A STUDENT LOGIN AS ADMIN -Run Cron -Go to course -Check Course Completion Report -Verify the assignment is shown as completed
    • Affected Branches:
      MOODLE_25_STABLE, MOODLE_26_STABLE, MOODLE_28_STABLE, MOODLE_29_STABLE, MOODLE_30_STABLE
    • Fixed Branches:
      MOODLE_28_STABLE, MOODLE_29_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-46078-master

      Description

      Issue: If a user's first submission on an assignment is in a status of "draft" no matter how many extra attempts the user makes with the "submitted" status, the Activity Completion will not complete.

      Steps to replicate:

      -Create a course, make sure to enable copletion tracking in the course
      -Enrol users into the course
      -Add an assignment to the course with the following options
      a) Submission Type - Online Text
      b) Feedback types - Feedback Comments
      c) Submission Settings - Require students click submit button - Yes
      d) Submission Settings - Require that students accept the submission statement - No
      e) Submission Settings - Attempts Reopened - Manually
      f) Submission Settings - Maximum Attempts - Unlimited
      g) Grade - Grade - Nograde
      h) Activity Completion - Student must submit to this activity to complete it - check
      -Add Course Completion settings
      a) General - Course is complete when ALL conditions are met
      b) Condition: Activity Completion - check the assignment created in previous step
      *LOGIN AS STUDENT*
      -Go to Activity
      -Click Add Submission
      -Enter something in text box
      -Click Save Changes
      -Notice Submission Status = "Draft (not submitted)"
      -Exit activity without doing anything on the "Submission Status" page
      *LOGOUt AS STUDENT*
      *LOGIN AS ADMIN*
      -Go to Assignment
      -View/Grade all Submissions
      -Look for submission
      -Go to Edit icon
      -Click "Allow Another Attempt"
      *LOGIN AS (SAME) STUDENT*
      -Go to the activity
      -Click "Add a new attempt based on previous submission"
      -Enter the submiision
      -Click "Submit Assignment"
      -Click "Continue"
      *LOGOUT AS A STUDENT*
      *LOGIN AS ADMIN*
      -Run Cron
      -Go to course
      -Check Course Completion Report
      -Assignment did not complete for that user despite the second submission being done properly

      Two possible workarounds:
      -Do not include that activity in the course completion. If already there, unlock status, and remove that activity, and reset the completion criteria
      -Insert the completion record directly in the DB (Though this maybe a good idea, whatever solution is devised, this may interfere with it)

      Please note that updating the status directly in the database from "draft" to "submitted" does not fix the issue

        Attachments

          Activity

            People

            • Votes:
              6 Vote for this issue
              Watchers:
              12 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                14/Sep/15