Moodle
  1. Moodle
  2. MDL-46093

Quiz review should default to show all questions

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.7
    • Fix Version/s: 2.8
    • Component/s: Quiz
    • Labels:
    • Testing Instructions:
      Hide
      1. Create a quiz with a few questions, say two pages each with two questions.
      2. Attempt it as a student.
      3. After you Submit all and finish, You should see a review of all the questions on one page.
      4. The links in the navigation should scroll the page to that question, without reloading the page
      5. Click 'Show one page at a time'
      6. Verify the question buttons in the navigation take you to the appropriate page. The first question on the page should take you to the top of the page. The other buttons should scroll you down to that question.
      7. Repeat with a quiz with more than 50 questions split over a number of pages. It should be similar except that the review will default to showing one page at a time, with a Show all questions on one page link to switch to the other view.
      Show
      Create a quiz with a few questions, say two pages each with two questions. Attempt it as a student. After you Submit all and finish, You should see a review of all the questions on one page. The links in the navigation should scroll the page to that question, without reloading the page Click 'Show one page at a time' Verify the question buttons in the navigation take you to the appropriate page. The first question on the page should take you to the top of the page. The other buttons should scroll you down to that question. Repeat with a quiz with more than 50 questions split over a number of pages. It should be similar except that the review will default to showing one page at a time, with a Show all questions on one page link to switch to the other view.
    • Affected Branches:
      MOODLE_27_STABLE
    • Fixed Branches:
      MOODLE_28_STABLE
    • Pull from Repository:
    • Pull Master Branch:

      Description

      ... unless the quiz is very big.

        Gliffy Diagrams

          Activity

          Hide
          Tim Hunt added a comment -

          I am going to choose a cut-off of 50 items (questions or descriptions). Quizzes shorter than that will default to reviewing the whole quiz on one page.

          Show
          Tim Hunt added a comment - I am going to choose a cut-off of 50 items (questions or descriptions). Quizzes shorter than that will default to reviewing the whole quiz on one page.
          Hide
          Tim Hunt added a comment -

          I think this works, and I think writing all the unit tests found all the mistakes I made.

          Show
          Tim Hunt added a comment - I think this works, and I think writing all the unit tests found all the mistakes I made.
          Hide
          CiBoT added a comment -

          Results for MDL-46093

          • Remote repository: git://github.com/timhunt/moodle.git
          Show
          CiBoT added a comment - Results for MDL-46093 Remote repository: git://github.com/timhunt/moodle.git Remote branch MDL-46093 to be integrated into upstream master Executed job http://integration.moodle.org/job/Precheck%20remote%20branch/4156 Details: http://integration.moodle.org/job/Precheck%20remote%20branch/4156/artifact/work/smurf.html
          Hide
          Tim Hunt added a comment -

          Hopefully I have dealt with the CiBoT issues.

          Show
          Tim Hunt added a comment - Hopefully I have dealt with the CiBoT issues.
          Hide
          CiBoT added a comment -

          Results for MDL-46093

          • Remote repository: git://github.com/timhunt/moodle.git
          Show
          CiBoT added a comment - Results for MDL-46093 Remote repository: git://github.com/timhunt/moodle.git Remote branch MDL-46093 to be integrated into upstream master Executed job http://integration.moodle.org/job/Precheck%20remote%20branch/4157 Details: http://integration.moodle.org/job/Precheck%20remote%20branch/4157/artifact/work/smurf.html
          Hide
          CiBoT added a comment -

          Results for MDL-46093

          • Remote repository: git://github.com/timhunt/moodle.git
          Show
          CiBoT added a comment - Results for MDL-46093 Remote repository: git://github.com/timhunt/moodle.git Remote branch MDL-46093 to be integrated into upstream master Executed job http://integration.moodle.org/job/Precheck%20remote%20branch/4158 Details: http://integration.moodle.org/job/Precheck%20remote%20branch/4158/artifact/work/smurf.html
          Hide
          Mahmoud Kassaei added a comment -

          The code looked fine. It was minor issues with one of the test in attempt_test.php which was pointed out and I think it is sorted.

          Show
          Mahmoud Kassaei added a comment - The code looked fine. It was minor issues with one of the test in attempt_test.php which was pointed out and I think it is sorted.
          Hide
          Tim Hunt added a comment -

          Thanks Mahmoud. Submitting for integration.

          Show
          Tim Hunt added a comment - Thanks Mahmoud. Submitting for integration.
          Hide
          CiBoT added a comment -

          Moving this issue to current integration cycle, will be reviewed soon. Thanks for the hard work!

          Show
          CiBoT added a comment - Moving this issue to current integration cycle, will be reviewed soon. Thanks for the hard work!
          Hide
          Dan Poltawski added a comment -

          This makes sense to me Tim - i'm curious though - has this come from specific user feedback/research?

          Show
          Dan Poltawski added a comment - This makes sense to me Tim - i'm curious though - has this come from specific user feedback/research?
          Hide
          Tim Hunt added a comment -

          Dan, you will see that this is part of the epic, and the epic links to a forum thread that explains the history, and has a lot of postitive user feedback. In brief:

          1. I noticed a pattern of comments in the quiz forum over a number of months and years from a range of people (too many clicks in the quiz getting in the way of student learning).
          2. At the hack-fest in Edinburgh, I grabbed Stuar Lamour and Bas Brands and talked it through and came up with a list of small changes that were almost certainly improvements, and very unlikely to be seen as bad changes by other people.
          3. Eventually, I found time to write this up in the quiz forum, and got an amazingly consitent agreement that most of the proposed changes were good ideas, so made epic and started coding.
          Show
          Tim Hunt added a comment - Dan, you will see that this is part of the epic, and the epic links to a forum thread that explains the history, and has a lot of postitive user feedback. In brief: I noticed a pattern of comments in the quiz forum over a number of months and years from a range of people (too many clicks in the quiz getting in the way of student learning). At the hack-fest in Edinburgh, I grabbed Stuar Lamour and Bas Brands and talked it through and came up with a list of small changes that were almost certainly improvements, and very unlikely to be seen as bad changes by other people. Eventually, I found time to write this up in the quiz forum, and got an amazingly consitent agreement that most of the proposed changes were good ideas, so made epic and started coding.
          Hide
          Dan Poltawski added a comment - - edited

          Sorry, I didn't notice the epic link, it was what I was looking for. (And I had seen the forum thread on the quiz forum before, just ddin't link these)

          Show
          Dan Poltawski added a comment - - edited Sorry, I didn't notice the epic link, it was what I was looking for. (And I had seen the forum thread on the quiz forum before, just ddin't link these)
          Hide
          Dan Poltawski added a comment -

          Integrated to master, thanks

          Show
          Dan Poltawski added a comment - Integrated to master, thanks
          Hide
          David Monllaó added a comment -

          Error after clicking 'Edit quiz' button just after creating it.

          Parse error: syntax error, unexpected 'echo' (T_ECHO), expecting ',' or ';' in /home/davidm/Desktop/moodlecode/INTEGRATION/master/question/classes/bank/search/category_condition.php on line 139
          Call Stack
          #	Time	Memory	Function	Location
          1	0.0009	386864	{main}( )	../edit.php:0
          2	0.4189	41257184	quiz_question_bank_view->display( )	../edit.php:507
          3	0.4192	41274608	core_component::classloader( )	../edit.php:0
          

          Show
          David Monllaó added a comment - Error after clicking 'Edit quiz' button just after creating it. Parse error: syntax error, unexpected 'echo' (T_ECHO), expecting ',' or ';' in /home/davidm/Desktop/moodlecode/INTEGRATION/master/question/classes/bank/search/category_condition.php on line 139 Call Stack # Time Memory Function Location 1 0.0009 386864 {main}( ) ../edit.php:0 2 0.4189 41257184 quiz_question_bank_view->display( ) ../edit.php:507 3 0.4192 41274608 core_component::classloader( ) ../edit.php:0
          Hide
          David Monllaó added a comment -

          Sending back to testing after checking what was breaking the syntax, I've commented on MDL-46163, I will test this issue after there is a solution for MDL-46163

          Show
          David Monllaó added a comment - Sending back to testing after checking what was breaking the syntax, I've commented on MDL-46163 , I will test this issue after there is a solution for MDL-46163
          Hide
          Dan Poltawski added a comment -

          [~davmon] a fix has been integrated - can you continue testing?

          Show
          Dan Poltawski added a comment - [~davmon] a fix has been integrated - can you continue testing?
          Hide
          Dan Poltawski added a comment -

          Noticed while testing, the random question popup looks horrible.

          Show
          Dan Poltawski added a comment - Noticed while testing, the random question popup looks horrible.
          Hide
          Dan Poltawski added a comment -

          It works, but the problem reported in MDL-40457 is currently crippling creation of quizzes with the inability to change category in quiz creation screen

          Show
          Dan Poltawski added a comment - It works, but the problem reported in MDL-40457 is currently crippling creation of quizzes with the inability to change category in quiz creation screen
          Hide
          David Monllaó added a comment -

          Thanks for taking this Dan, I left early Yesterday and I didn't have time to complete all tests.

          Show
          David Monllaó added a comment - Thanks for taking this Dan, I left early Yesterday and I didn't have time to complete all tests.
          Hide
          Dan Poltawski added a comment -

          This change is now part of Moodle! Thanks for your contribution!

          Before software can be reusable it first has to be usable.
          --Ralph Johnson

          Show
          Dan Poltawski added a comment - This change is now part of Moodle! Thanks for your contribution! Before software can be reusable it first has to be usable. --Ralph Johnson
          Hide
          Joshua Bragg added a comment -

          Docs have been updated: https://docs.moodle.org/28/en/Using_Quiz#How_students_review_a_quiz
          Removing docs_required label.

          Show
          Joshua Bragg added a comment - Docs have been updated: https://docs.moodle.org/28/en/Using_Quiz#How_students_review_a_quiz Removing docs_required label.

            People

            • Votes:
              1 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: