[MDL-46123] get_component_string should be improved - Moodle Tracker

XML

Word

Printable

Details

Type: Improvement
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 2.8, 3.9
Fix Version/s: 3.9
Component/s: Libraries
Labels:
- ci
- triaged

Affected Branches:
MOODLE_28_STABLE, MOODLE_39_STABLE
Fixed Branches:
MOODLE_39_STABLE
Epic Link:
TODOs in core
Pull from Repository:
https://github.com/stronk7/moodle.git
Pull Master Branch:
~~MDL-46123~~
Pull Master Diff URL:
https://github.com/stronk7/moodle/compare/MDL-46123~1...MDL-46123
Testing Instructions:
1. Go to Admin -> Users -> Permissions -> Define roles.
2. Click the icon to edit any role of your choice.
3. Verify that all the component names are shown nicely.

Description

This issue came about because of a TODO without an accompanying tracker issue.

lib/accesslib.php get_component_string contains a todo above some really hacky code that includes badly structured strings.
It would be great to improve this (finally) at some point.

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

image-2019-12-04-09-07-19-820.png
113 kB
04/Dec/19 9:07 AM

Issue Links

has been marked as being related by

MDL-67439 Add the plugintype to all components in the roles edition screens

Open

Activity

People

Assignee:: Tim Hunt

Reporter:: Sam Hemelryk

Peer reviewer:: Sam Marshall

Integrator:: Eloy Lafuente (stronk7)

Tester:: Janelle Barcega

Participants:: CiBoT, Eloy Lafuente (stronk7), Janelle Barcega, Marina Glancy, Sam Hemelryk, Sam Marshall, Tim Hunt

Component watchers:: David Woloszyn, Huong Nguyen, Jake Dallimore, Michael Hawkins, Stevani Andolo

Votes:: 0 Vote for this issue

Watchers:: 5 Start watching this issue

Dates

Created:: 25/Jun/14 1:10 PM

Updated:: 05/Dec/19 8:46 PM

Resolved:: 05/Dec/19 8:46 PM

Fix Release Date:: 15/Jun/20

Time Tracking

Estimated:

Not Specified

Remaining:

Logged:

1h 56m