Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-46200

Missing space in failed login message

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.7
    • Fix Version/s: 2.7.1
    • Component/s: Blocks
    • Labels:
    • Testing Instructions:
      Hide
      1. Enable displayloginfailures in your moodle
      2. Log out of Moodle
      3. Attempt to login to Moodle with the wrong password a few times
      4. Login as admin
      5. VERIFY: the login failures message is displayed and has a space in it
      Show
      Enable displayloginfailures in your moodle Log out of Moodle Attempt to login to Moodle with the wrong password a few times Login as admin VERIFY: the login failures message is displayed and has a space in it
    • Affected Branches:
      MOODLE_27_STABLE
    • Fixed Branches:
      MOODLE_27_STABLE
    • Pull Master Branch:
      MDL-46200-master

      Description

      In lib/outputrenderers.php, function login_info(), there is a space missing:

      $loggedinas .= '<div class="loginfailures">';
      $a = new stdClass();
      $a->attempts = $count;
      $loggedinas .= get_string('failedloginattempts', '', $a);
      if (file_exists("$CFG->dirroot/report/log/index.php") and has_capability('report/log:view', context_system::instance()))

      { - $loggedinas .= html_writer::link(new moodle_url('/report/log/index.php', array('chooselog' => 1, 'id' => 0 , 'modid' => 'site_errors')), '(' . get_string('logs') . ')'); + $loggedinas .= html_writer::link(new moodle_url('/report/log/index.php', array('chooselog' => 1, 'id' => 0 , 'modid' => 'site_errors')), ' (' . get_string('logs') . ')'); }

      $loggedinas .= '</div>';

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  14/Jul/14