Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-46207

Scheduled tasks should consider the enabled state of a plugin

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Install the dummy text editor attached to this issue.
      Run cron
      Verify you see "I ALWAYS RUN!!!!!!!!!!!!!!!!!!!!!!!!Unable to render embedded object: File (" in the cron output, but did not see "I RAN) not found.!!!!!!!!!!!!!!!!!!!".
      Enable the new text editor plugin (manage text editors page).
      Run cron again (it will need to be at least 60 seconds after last cron run).
      Verify you see "I ALWAYS RUN!!!!!!!!!!!!!!!!!!!!!!!!Unable to render embedded object: File (" in the cron output, and see "I RAN) not found.!!!!!!!!!!!!!!!!!!!" in the cron output.

      Show
      Install the dummy text editor attached to this issue. Run cron Verify you see "I ALWAYS RUN!!!!!!!!!!!!!!!!!!!!!!!! Unable to render embedded object: File (" in the cron output, but did not see "I RAN) not found. !!!!!!!!!!!!!!!!!!!". Enable the new text editor plugin (manage text editors page). Run cron again (it will need to be at least 60 seconds after last cron run). Verify you see "I ALWAYS RUN!!!!!!!!!!!!!!!!!!!!!!!! Unable to render embedded object: File (" in the cron output, and see "I RAN) not found. !!!!!!!!!!!!!!!!!!!" in the cron output.
    • Affected Branches:
      MOODLE_27_STABLE
    • Fixed Branches:
      MOODLE_28_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-46207-master
    • Pull Master Diff URL:

      Description

      In MDL-45932, Damyon wrote:

      Finally - the cron function will need to be modified to not do anything if the plugin is not enabled. Legacy cron does not call cron in disabled plugins - but scheduled tasks does not consider this. enrol_is_enabled() will do the trick.

      This seems like a regression to me, if a plugin is disabled my expectation is that core ensures that no code from it is called in cron.

      I guessed this was because we don't have the right hook for it, but David Mudrák (@mudrd8mz) mentions that we have core\plugininfo\base::is_enabled()

        Attachments

          Issue Links

          caused a regression

          Sub-task - Issues are sometimes broken into multiple sub-tasks. MDL-47206 Allow 'tool' plugins to run scheduled tasks

          • Minor - Minor loss of function where workaround is possible
          • Closed

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-48156 Schedule task manager misinterprets core\plugininfo\base::is_enabled()

          • Blocker - Blocks development and/or testing, prevents Moodle from running (applicable to bugs only)
          • Closed

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-48383 Cron warns about disabled enrol_imsenterprise after each scheduled task

          • Major - Major loss of function, incorrect output
          • Closed

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDLSITE-3593 The task local_plugins\task\update_download_stats not execute since Oct 27

          • Minor - Minor loss of function where workaround is possible
          • Closed
          has been marked as being related by

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDLSITE-3593 The task local_plugins\task\update_download_stats not execute since Oct 27

          • Minor - Minor loss of function where workaround is possible
          • Closed
          Testing discovered

          Improvement - An enhancement to an existing Moodle feature. MDL-45932 Implement Scheduled Task for IMS Enrolment plugin

          • Minor - Minor loss of function where workaround is possible
          • Closed

            Activity

              People

              Assignee:
              damyon Damyon Wiese
              Reporter:
              poltawski Dan Poltawski
              Peer reviewer:
              Ankit Agarwal
              Integrator:
              Sam Hemelryk
              Tester:
              Andrew Davis
              Participants:
              Component watchers:
              Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón
              Votes:
              2 Vote for this issue
              Watchers:
              8 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                10/Nov/14