[MDL-46207] Scheduled tasks should consider the enabled state of a plugin - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: 2.7
Fix Version/s: 2.8
Component/s: Administration, Libraries
Labels:
- ci
- triaged

Affected Branches:
MOODLE_27_STABLE
Fixed Branches:
MOODLE_28_STABLE
Pull from Repository:
git://github.com/damyon/moodle.git
Pull Master Branch:
~~MDL-46207~~-master
Pull Master Diff URL:
https://github.com/damyon/moodle/compare/584539c0fc26447c5b7dab89eecc37950ed75321...MDL-46207-master
Testing Instructions:

Hide

Install the dummy text editor attached to this issue.
Run cron
Verify you see "I ALWAYS RUN!!!!!!!!!!!!!!!!!!!!!!!!Unable to render embedded object: File (" in the cron output, but did not see "I RAN) not found.!!!!!!!!!!!!!!!!!!!".
Enable the new text editor plugin (manage text editors page).
Run cron again (it will need to be at least 60 seconds after last cron run).
Verify you see "I ALWAYS RUN!!!!!!!!!!!!!!!!!!!!!!!!Unable to render embedded object: File (" in the cron output, and see "I RAN) not found.!!!!!!!!!!!!!!!!!!!" in the cron output.

Show
Install the dummy text editor attached to this issue. Run cron Verify you see "I ALWAYS RUN!!!!!!!!!!!!!!!!!!!!!!!! Unable to render embedded object: File (" in the cron output, but did not see "I RAN) not found. !!!!!!!!!!!!!!!!!!!". Enable the new text editor plugin (manage text editors page). Run cron again (it will need to be at least 60 seconds after last cron run). Verify you see "I ALWAYS RUN!!!!!!!!!!!!!!!!!!!!!!!! Unable to render embedded object: File (" in the cron output, and see "I RAN) not found. !!!!!!!!!!!!!!!!!!!" in the cron output.

Description

Finally - the cron function will need to be modified to not do anything if the plugin is not enabled. Legacy cron does not call cron in disabled plugins - but scheduled tasks does not consider this. enrol_is_enabled() will do the trick.

This seems like a regression to me, if a plugin is disabled my expectation is that core ensures that no code from it is called in cron.

I guessed this was because we don't have the right hook for it, but mudrd8mz mentions that we have core\plugininfo\base::is_enabled()

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

tasktest.tar.gz
2 kB
21/Jul/14 10:57 PM

Issue Links

caused a regression

MDL-47206 Allow 'tool' plugins to run scheduled tasks

Closed

MDL-48156 Schedule task manager misinterprets core\plugininfo\base::is_enabled()

Closed

MDL-48383 Cron warns about disabled enrol_imsenterprise after each scheduled task

Closed

MDLSITE-3593 The task local_plugins\task\update_download_stats not execute since Oct 27

Closed

has been marked as being related by

MDLSITE-3593 The task local_plugins\task\update_download_stats not execute since Oct 27

Closed

Testing discovered

MDL-45932 Implement Scheduled Task for IMS Enrolment plugin

Closed

(1 Testing discovered)

Activity

People

Assignee:: Damyon Wiese

Reporter:: Dan Poltawski

Peer reviewer:: Ankit Agarwal

Integrator:: Sam Hemelryk

Tester:: Andrew Davis

Participants:: Andrew Davis, Ankit Agarwal, CiBoT, Damyon Wiese, Dan Poltawski, David Mudrák (@mudrd8mz), Marina Glancy, Petr Skoda, Sam Hemelryk

Component watchers:: David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo, David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo

Votes:: 2 Vote for this issue

Watchers:: 8 Start watching this issue

Dates

Created:: 01/Jul/14 7:07 AM

Updated:: 06/May/15 8:36 PM

Resolved:: 01/Aug/14 2:30 AM

Fix Release Date:: 10/Nov/14