Moodle
  1. Moodle
  2. MDL-4625

An comment and environment bug in block rss_client (with patch)

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0
    • Fix Version/s: None
    • Component/s: Blocks
    • Labels:
      None
    • Environment:
      All
    • Affected Branches:
      MOODLE_20_STABLE
    • Rank:
      11180

      Description

      The bug cause what I have reported in MDL-3392.

      The BLOCK_RSS_SECONDARY_CACHE (provided by moodle)caches rss items only, not include the rss feed's title, link and etc.

      For my opinion, magpie already has a wonderful cache. Why not use it directly? My patch just closes the moodle rss cache and uses magpie's.

      Index: block_rss_client.php

      ===================================================================

      — block_rss_client.php (revision 392)

      +++ block_rss_client.php (working copy)

      @@ -11,9 +11,9 @@

      • @package base

      ******************************************************************/

      -// Developer's debug assistant - if true then the display string will not cache, only

      +// Developer's debug assistant - if false then the display string will not cache, only

      // the magpie object's built in caching will be used

      -define('BLOCK_RSS_SECONDARY_CACHE_ENABLED', true);

      +define('BLOCK_RSS_SECONDARY_CACHE_ENABLED', false);

      /**

      • This class is for a block which defines a block for display on

        Activity

        Hide
        Martin Dougiamas added a comment -

        From Eloy Lafuente (stronk7 at moodle.org) Monday, 23 January 2006, 08:14 AM:

        Is this yours, Daryl? Or am I wrong and should I switch it back to Jon?

        Any idea? Ciao

        From Jon Papaioannou (pj at moodle.org) Sunday, 29 January 2006, 01:52 AM:

        This is Daryl's, and probably there's some reason for the decision... but I know just as much as you do, Eloy.

        From Eloy Lafuente (stronk7 at moodle.org) Sunday, 29 January 2006, 03:23 AM:

        Well, let's wait for Daryl's answer some days.... thanks!

        From Daryl Hawes (dhawes at mac.com) Friday, 3 March 2006, 01:09 AM:

        Finally fixed this bug. While I was chaching the return string of the body of the RSS message I was not chachine block specific items such as $this->title. As a solution I've removed the secondary cache (memory cache of read in rss feeds) to avoid this issue completely. Fixed in HEAD and 1.5.3 branch.

        From Eloy Lafuente (stronk7 at moodle.org) Friday, 3 March 2006, 06:08 PM:

        Cool! B-)

        Show
        Martin Dougiamas added a comment - From Eloy Lafuente (stronk7 at moodle.org) Monday, 23 January 2006, 08:14 AM: Is this yours, Daryl? Or am I wrong and should I switch it back to Jon? Any idea? Ciao From Jon Papaioannou (pj at moodle.org) Sunday, 29 January 2006, 01:52 AM: This is Daryl's, and probably there's some reason for the decision... but I know just as much as you do, Eloy. From Eloy Lafuente (stronk7 at moodle.org) Sunday, 29 January 2006, 03:23 AM: Well, let's wait for Daryl's answer some days.... thanks! From Daryl Hawes (dhawes at mac.com) Friday, 3 March 2006, 01:09 AM: Finally fixed this bug. While I was chaching the return string of the body of the RSS message I was not chachine block specific items such as $this->title. As a solution I've removed the secondary cache (memory cache of read in rss feeds) to avoid this issue completely. Fixed in HEAD and 1.5.3 branch. From Eloy Lafuente (stronk7 at moodle.org) Friday, 3 March 2006, 06:08 PM: Cool! B-)
        Hide
        Michael Blake added a comment -

        Temp reopen to assign to a valid user. Daryl Hawes.

        Show
        Michael Blake added a comment - Temp reopen to assign to a valid user. Daryl Hawes.
        Hide
        Michael Blake added a comment -

        Reassigning to a valid user.

        Show
        Michael Blake added a comment - Reassigning to a valid user.

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: