Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-46267

Final deprecation of https_required and verify_https_required, remove loginhttps and httpswwwroot if possible

    XMLWordPrintable

Details

    • MOODLE_28_STABLE, MOODLE_38_STABLE
    • MOODLE_38_STABLE
    • MDL-46267-master
    • Hide
      1. Search for `https_required`.

        git grep https_required
        

      2. Confirm that the only occurrences that you see are in lib/pagelib.php and lib/upgrade.txt
      3. Search for '$CFG->httpswwwroot'

        git grep '$CFG->httpswwwroot'
        

      4. Confirm that you don't get any results except for the mentions in lib/upgrade.txt.

      CI will handle the rest of the automated tests which should still pass.

      Show
      Search for `https_required`. git grep https_required Confirm that the only occurrences that you see are in lib/pagelib.php and lib/upgrade.txt Search for '$CFG->httpswwwroot' git grep '$CFG->httpswwwroot' Confirm that you don't get any results except for the mentions in lib/upgrade.txt. CI will handle the rest of the automated tests which should still pass.
    • 1
    • Sprint 2 - Experimental, Sprint 3 - Investimerental

    Description

      Remove functions https_required and verify_required from lib/pagelib.php

      Probably can't remove httpswwwroot as it has no way to be deprecated before removal

      Remove loginhttps from all places in core (e.g. lib/setup.php)

      Attachments

        Issue Links

          Activity

            People

              jpataleta Jun Pataleta
              johno John Okely
              Ryan Wyllie Ryan Wyllie
              Jake Dallimore Jake Dallimore
              Anna Carissa Sadia Anna Carissa Sadia
              Votes:
              2 Vote for this issue
              Watchers:
              10 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 2 hours, 30 minutes
                  2h 30m

                  Clockify

                    Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.