Loading...

XML

Word

Printable

Affected Branches:
MOODLE_28_STABLE, MOODLE_38_STABLE
Fixed Branches:
MOODLE_38_STABLE
Epic Link:
3.8 deprecations
Pull from Repository:
git://github.com/junpataleta/moodle.git
Pull Main Branch:
~~MDL-46267~~-master
Pull Main Diff URL:
https://github.com/junpataleta/moodle/compare/8d9614b341...MDL-46267-master
Testing Instructions:
Hide

Search for `https_required`.

git grep https_required

Confirm that the only occurrences that you see are in lib/pagelib.php and lib/upgrade.txt

Search for '$CFG->httpswwwroot'

git grep '$CFG->httpswwwroot'

Confirm that you don't get any results except for the mentions in lib/upgrade.txt.

CI will handle the rest of the automated tests which should still pass.
Show
Search for `https_required`. git grep https_required Confirm that the only occurrences that you see are in lib/pagelib.php and lib/upgrade.txt Search for '$CFG->httpswwwroot' git grep '$CFG->httpswwwroot' Confirm that you don't get any results except for the mentions in lib/upgrade.txt. CI will handle the rest of the automated tests which should still pass.

Remove functions https_required and verify_required from lib/pagelib.php

Probably can't remove httpswwwroot as it has no way to be deprecated before removal

Remove loginhttps from all places in core (e.g. lib/setup.php)

caused a regression

MDL-67250 Removal of httpswwwroot would break a lot of plugins and is not really needed

is blocked by

MDL-42834 Deprecate loginhttps

Participants:: Anna Carissa Sadia, CiBoT, David Mudrák (@mudrd8mz), Jake Dallimore, John Okely, Juan Leyva, Jun Pataleta, Marina Glancy, Ryan Wyllie

Estimated:

Not Specified

Remaining:

Logged:

2h 30m