Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-46286

Add allowed URI scheme for RTMP streams in HTML Purifier library

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.7
    • Fix Version/s: 2.8
    • Component/s: Libraries
    • Labels:
    • Affected Branches:
      MOODLE_27_STABLE
    • Fixed Branches:
      MOODLE_28_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-46286-master
    • Testing Instructions:
      Hide

      PHPUnit test included in patch.

      To test manually would require the installation of an RTMP filter/player such as https://moodle.org/plugins/view.php?plugin=filter_rtmp.

      • Install RTMP filter/player as above.
      • Disable trusted content or log in as a user without the 'trustcontent' capability.
      • Add a forum post and include a link to an RTMP stream.
      • Save the post and make sure the linked stream is displayed in a suitable embedded multimedia player.
      Show
      PHPUnit test included in patch. To test manually would require the installation of an RTMP filter/player such as https://moodle.org/plugins/view.php?plugin=filter_rtmp . Install RTMP filter/player as above. Disable trusted content or log in as a user without the 'trustcontent' capability. Add a forum post and include a link to an RTMP stream. Save the post and make sure the linked stream is displayed in a suitable embedded multimedia player.

      Description

      Currently, including an RTMP stream in a forum post results in the href attribute being removed by HTML Purifier (unless trusted content is enabled and the user has the 'trustcontent' capability).

      This patch adds an allowed URI scheme to HTML Purifier which enables any user to include RTMP streams in their posts.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              tonybutler Tony Butler
              Reporter:
              tonybutler Tony Butler
              Peer reviewer:
              Petr Skoda Petr Skoda
              Integrator:
              Dan Poltawski Dan Poltawski
              Tester:
              Andrew Lyons Andrew Lyons
              Participants:
              Component watchers:
              Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                10/Nov/14