Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-46290

Deprecate unused function get_incomplete_criteria(), it doesn't work

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.7
    • Fix Version/s: 2.8
    • Component/s: Course completion
    • Labels:
    • Testing Instructions:
      Hide
      • Install the attached plugin which calls the method.
      • Set developer debugging on
      • Click Administration > Reports > Test get_incomplete_criteria()
      • Note that a warning message is shown before the fatal error caused by the method being wrong
      Show
      Install the attached plugin which calls the method. Set developer debugging on Click Administration > Reports > Test get_incomplete_criteria() Note that a warning message is shown before the fatal error caused by the method being wrong
    • Affected Branches:
      MOODLE_27_STABLE
    • Fixed Branches:
      MOODLE_28_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-46290_remove_unused_get_incomplete_criteria
    • Pull Master Diff URL:

      Description

      In lib/completionlib.php, get_incomplete_criteria() doesn't seem to be used anywhere. It is good that it's unused, because I don't see any way it could work - it doesn't take a $userid parameter.

      I propose that it be removed.

        Attachments

          Issue Links

          has been marked as being related by

          Task - A task that needs to be completed. Tasks usually refer to work that must be done outside the product. MDL-46294 Remove get_incomplete_criteria()

          • Minor - Minor loss of function where workaround is possible
          • Closed

            Activity

              People

              Assignee:
              raymor Ray Morris
              Reporter:
              raymor Ray Morris
              Peer reviewer:
              David Monllaó David Monllaó
              Integrator:
              Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
              Tester:
              Michael de Raadt Michael de Raadt
              Participants:
              Component watchers:
              Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                10/Nov/14