Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-46290

Deprecate unused function get_incomplete_criteria(), it doesn't work

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • 2.8
    • 2.7
    • Course completion
    • MOODLE_27_STABLE
    • MOODLE_28_STABLE
    • MDL-46290_remove_unused_get_incomplete_criteria
    • Hide
      • Install the attached plugin which calls the method.
      • Set developer debugging on
      • Click Administration > Reports > Test get_incomplete_criteria()
      • Note that a warning message is shown before the fatal error caused by the method being wrong
      Show
      Install the attached plugin which calls the method. Set developer debugging on Click Administration > Reports > Test get_incomplete_criteria() Note that a warning message is shown before the fatal error caused by the method being wrong

      In lib/completionlib.php, get_incomplete_criteria() doesn't seem to be used anywhere. It is good that it's unused, because I don't see any way it could work - it doesn't take a $userid parameter.

      I propose that it be removed.

        1. report_testincomplete.zip
          4 kB

            raymor Ray Morris
            raymor Ray Morris
            David Monllaó David Monllaó
            Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
            Michael de Raadt Michael de Raadt
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.