Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-46290

Deprecate unused function get_incomplete_criteria(), it doesn't work

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 2.7
    • 2.8
    • Course completion
    • MOODLE_27_STABLE
    • MOODLE_28_STABLE
    • MDL-46290_remove_unused_get_incomplete_criteria
    • Hide
      • Install the attached plugin which calls the method.
      • Set developer debugging on
      • Click Administration > Reports > Test get_incomplete_criteria()
      • Note that a warning message is shown before the fatal error caused by the method being wrong
      Show
      Install the attached plugin which calls the method. Set developer debugging on Click Administration > Reports > Test get_incomplete_criteria() Note that a warning message is shown before the fatal error caused by the method being wrong

    Description

      In lib/completionlib.php, get_incomplete_criteria() doesn't seem to be used anywhere. It is good that it's unused, because I don't see any way it could work - it doesn't take a $userid parameter.

      I propose that it be removed.

      Attachments

        Issue Links

          Activity

            People

              raymor Ray Morris
              raymor Ray Morris
              David Monllaó David Monllaó
              Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
              Michael de Raadt Michael de Raadt
              Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                10/Nov/14