Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-46296

Improve validation of scheduled tasks

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Deferred
    • Affects Version/s: 2.7
    • Fix Version/s: None
    • Component/s: Forms Library, General
    • Labels:
    • Affected Branches:
      MOODLE_27_STABLE
    • Sprint:
      Team B Sprint 1

      Description

      Detected while testing MDL-46227, it seems that the "cron" fields available when editing a task schedule are using a relaxed PARAM_RAW without any extra check. See:

      https://tracker.moodle.org/browse/MDL-46227?focusedCommentId=298749&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-298749

      It would be great to validate a bit more what's entered in those fields, surely some regexp could reduce at least the available chars, or perhaps that validation/cleaning is already available somewhere in the tasks API. Just current behavior seems too much relaxed.

      For your consideration, ciao

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              ankit_frenz Ankit Agarwal
              Reporter:
              stronk7 Eloy Lafuente (stronk7)
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan, Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan
              Votes:
              1 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: