Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-46316

Fix coding style problems in notes

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.8
    • Fix Version/s: 2.8
    • Component/s: Administration
    • Labels:
    • Testing Instructions:
      Hide
      1. No particular testing is required as only comments were changed. You can go to course participants, click a student, click "notes" under that student in the nav block and check that you can still add/edit/delete notes.
      2. Run codechecker on notes/ and verify that only externallib and externalibtest.php have coding style issues present
      Show
      No particular testing is required as only comments were changed. You can go to course participants, click a student, click "notes" under that student in the nav block and check that you can still add/edit/delete notes. Run codechecker on notes/ and verify that only externallib and externalibtest.php have coding style issues present
    • Affected Branches:
      MOODLE_28_STABLE
    • Fixed Branches:
      MOODLE_28_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-46316_notes2
    • Story Points:
      5
    • Sprint:
      FRONTEND Sprint 13

      Description

      code checker currently reports 50 errors and 103 warnings just in notes.

        Attachments

          Issue Links

          blocks

          Improvement - An enhancement to an existing Moodle feature. MDL-46430 lots of hardcoded html in /notes

          • Minor - Minor loss of function where workaround is possible
          • Development in progress
          is blocked by

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-46218 Disabled functionality checks occur later than necessary

          • Minor - Minor loss of function where workaround is possible
          • Closed
          Testing discovered

          Improvement - An enhancement to an existing Moodle feature. MDL-46430 lots of hardcoded html in /notes

          • Minor - Minor loss of function where workaround is possible
          • Development in progress

            Activity

              People

              Assignee:
              andyjdavis Andrew Davis
              Reporter:
              andyjdavis Andrew Davis
              Peer reviewer:
              Jetha Chan
              Integrator:
              Dan Poltawski
              Tester:
              Mark Nelson
              Participants:
              Component watchers:
              Andrew Nicols, Dongsheng Cai, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                10/Nov/14