Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-46387

Atto Subscript and Superscript Buttons Don't Toggle Like the Other Buttons in Chrome

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Run behat tests @atto_subscript @atto_supperscript
      With various browsers:

      1. Open a page with an Atto editor on it.
      2. Enter some text and add multiple char subscript to some text with button.
      3. Select part of the subscript and click subscript button.
      4. Verify that selected text becomes normal (not subscript of subscript)
      5. Create multiple char subscript again and make subscript bold or italic with formating button.
      6. Select part of the subscript and click subscript again and verify that selection toggles to normal.
      7. Click within formated subscript to position cursor, click subscript or superscript button and type a character.
      8. Verify character is inserted at default not at another subscript level.
      9. Repeat previous steps with superscript rather than subscript.
      10. View HTML source for the editor content and verify that no extra attributes are added to the subscript and superscript tags.

      Second test (from dan from linked issue):
      1. Click Subscript
      2. Write something
      3. Click underscore
      4. Write something
      5. Click Subscript

      Verify subscript doesn't add double level

      Show
      Run behat tests @atto_subscript @atto_supperscript With various browsers: Open a page with an Atto editor on it. Enter some text and add multiple char subscript to some text with button. Select part of the subscript and click subscript button. Verify that selected text becomes normal (not subscript of subscript) Create multiple char subscript again and make subscript bold or italic with formating button. Select part of the subscript and click subscript again and verify that selection toggles to normal. Click within formated subscript to position cursor, click subscript or superscript button and type a character. Verify character is inserted at default not at another subscript level. Repeat previous steps with superscript rather than subscript. View HTML source for the editor content and verify that no extra attributes are added to the subscript and superscript tags. Second test (from dan from linked issue): 1. Click Subscript 2. Write something 3. Click underscore 4. Write something 5. Click Subscript Verify subscript doesn't add double level
    • Affected Branches:
      MOODLE_27_STABLE, MOODLE_28_STABLE
    • Fixed Branches:
      MOODLE_28_STABLE, MOODLE_29_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-46387-master

      Description

      The subscript and superscript buttons should be toggle buttons that behave like bold and italics.

      Instead if you try to type H<sub>2</sub>O you get H<sub>2<sub>O</sub></sub>.

      Tested on Chrome 36.0.1985.125 m

      Note: The original problem could not be reproduced at the first integration attempt and afterwards. Changes appear to have been made in Chrome. However, in the follow up testing with the following problems were found.
      Chrome:

      1. Type H20
      2. Select 20 and click subscript
      3. Select 0 and click subscript
        Expected: html is H<sub>2</sub>O, Actual: About half the time it is H<sub><span>2</span><span><sub>O</sub></span></sub> or some permutation.
        Also try
      4. Type H20
      5. Select 20 and click subscript
      6. Click italic
        Expected: html is H<sub><i>2</i></sub><i>O</i>, Actual: H<sub><i>2<sub>O</sub></i></sub>

      Firefox and IE:

      1. Type H20
      2. Select 20 and click subscript
      3. Select 0 and click superscript
        Expected: html is H<sub>2</sub>O or H<sub>2</sub><sup>O<sup>, Actual H<sub>2<sup>O</sup></sub>

      IE:

      1. Type H20
      2. Select 20 and click subscript
      3. Click between 2 and 0 and click superscript
        Expected: Will wait for character to be typed and placed at default, Actual: H20 (the whole subscript is removed immediately)

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                1 Vote for this issue
                Watchers:
                13 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  14/Sep/15