[MDL-46408] PHP error in SCORM module - Moodle Tracker

XML

Word

Printable

Affected Branches:
MOODLE_27_STABLE, MOODLE_28_STABLE
Fixed Branches:
MOODLE_27_STABLE, MOODLE_28_STABLE
Pull from Repository:
https://github.com/danmarsden/moodle.git
Pull Master Branch:
master_~~MDL-46408~~
Pull Master Diff URL:
https://github.com/danmarsden/moodle/compare/moodle:master...master_MDL-46408
Testing Instructions:
Hide

With developer debugging and display errors turned on, Use attached SCORM package for SCORM activity

Create SCORM activity with package attached.

Click Save and display and make sure no PHP errors appear.
Show
With developer debugging and display errors turned on, Use attached SCORM package for SCORM activity Create SCORM activity with package attached. Click Save and display and make sure no PHP errors appear.

Using attached SCORM package for SCORM activity result in following php error.

Notice: Undefined property: stdClass::$defaultorg in /home/rajesht/moodles/im/moodle/mod/scorm/datamodels/scormlib.php on line 567

Steps to reproduce:

You will see following notice

Undefined offset: 0 in /home/rajesht/moodles/im/moodle/mod/scorm/locallib.php on line 1826

Not sure, if package is correct, but moodle should handle this gracefully.

Discovered while testing

MDL-35870 improving caching of SCORM JS and improve general structure.

Participants:: Andrew Lyons, CiBoT, Dan Marsden, Dan Poltawski, Dave Cooper, Marina Glancy, Rajesh Taneja

Component watchers:: Dan Marsden, Matteo Scaramuccia, Ilya Tregubov, Kevin Percy, Mathew May, Mihail Geshoski, Shamim Rezaie