Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-46424

Error message for uploading a file larger than size limit different between drag & drop and "Add" button.

    XMLWordPrintable

    Details

      Description

      I have customised the Error dialog text presented when dragging a too-large file onto the target area for assignment file uploads (linking to some optimization guidance), but later had reports that the change wasn't there.

      Eventually I found that the change wasn't present when uploading without using drag and drop, because the two dialogs use different lang strings - even though they serve the same purpose.

      • DnD uses 'maxbytesforfile' in moodle.php: 'The file {$a} is larger than the maximum size allowed.'.
      • Add button uses 'maxbytes' in error.php: 'The file is larger than the maximum size allowed.'.

      Should the Add button's use of 'maxbytes' be replaced with 'maxbytesforfile' - for consistency and the information? (I.e. if I fixed it on a branch, it would be integrated - or is the non-DnD method not of that much interest?)

        Attachments

          Activity

            People

            Assignee:
            rushi963 Rushikesh Nalla
            Reporter:
            balchd Dave Balch
            Peer reviewer:
            David Monllaó
            Integrator:
            Dan Poltawski
            Tester:
            cameron1729
            Participants:
            Component watchers:
            Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
            Votes:
            0 Vote for this issue
            Watchers:
            9 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              14/Mar/16