Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-46431

show_confirm_dialog has a h1 heading tag

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. Create a module that creates a confirmation dialogue box (or pick something that already has one).
      2. Trigger the dialogue.
      3. Using your favourite firebug clone, inspect the title bar.
        Currently this is a h1 tag, and (in my opinion) should be a h3 tag.
      1. Create a module that creates a Moodle alert dialogue box (or pick something that already has one).
      2. Trigger the dialogue.
      3. Using your favourite firebug clone, inspect the title bar.
        Currently this is a h1 tag, and (in my opinion) should be a h3 tag.
      1. Create a module that creates a Moodle exception dialogue box (or pick something that already has one).
      2. Trigger the dialogue.
      3. Using your favourite firebug clone, inspect the title bar.
        Currently this is a h1 tag, and (in my opinion) should be a h3 tag.
      1. Create a module that creates a Moodle Ajax exception dialogue box (or pick something that already has one).
      2. Trigger the dialogue.
      3. Using your favourite firebug clone, inspect the title bar.
        Currently this is a h1 tag, and (in my opinion) should be a h3 tag.
      Show
      Create a module that creates a confirmation dialogue box (or pick something that already has one). Trigger the dialogue. Using your favourite firebug clone, inspect the title bar. Currently this is a h1 tag, and (in my opinion) should be a h3 tag. Create a module that creates a Moodle alert dialogue box (or pick something that already has one). Trigger the dialogue. Using your favourite firebug clone, inspect the title bar. Currently this is a h1 tag, and (in my opinion) should be a h3 tag. Create a module that creates a Moodle exception dialogue box (or pick something that already has one). Trigger the dialogue. Using your favourite firebug clone, inspect the title bar. Currently this is a h1 tag, and (in my opinion) should be a h3 tag. Create a module that creates a Moodle Ajax exception dialogue box (or pick something that already has one). Trigger the dialogue. Using your favourite firebug clone, inspect the title bar. Currently this is a h1 tag, and (in my opinion) should be a h3 tag.
    • Affected Branches:
      MOODLE_27_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      m28_MDL-46431

      Description

      When a call is made to the Javascript M.util.show_confirm_dialog(), the heading is an h1. This usually means that there is more than 1 h1 per page.

      Personally I would look to make it a h3 as most pages will have a h1 (being the course name or site name) and a h2 (saying what the page is)

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated: