Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-46442

Assign: missing notification on submission when it has been already notified about before

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Hint: With the user that you grade, make their email something you can access then run cron when prompted to below to see the email come through and confirm it works.

      Test One:

      • Create an assignment.
      • Submit something as a student.
      • Edit grade (marker, feedback, whatever) and set 'notify student: yes'.
      • Run cron, php admin/cli/cron.php (note: you may have to wait up to a minute before running this if you have run it recently)
      • Ensure that notifications is sent.
      • Edit the grade again and set 'notify student: yes'
      • Run cron, php admin/cli/cron.php (note: you may have to wait up to a minute before running this if you have run it recently)
      • Ensure that notification is sent.

      Test Two:

      • Use quick-grading from the assignment page to change a students grade. (ensure at the bottom, notify student is set to YES)
      • Hit enter or the quick-save button.
      • Run cron, php admin/cli/cron.php (note: you may have to wait up to a minute before running this if you have run it recently)
      • Should receive a email.
      • Repeat the above but change notify student to NO.
      • Should NOT receive any emails.

      Probably wise to grade the same assignment again but this time set 'notify student: no' and make sure it doesn't send too.

      Test Three:

      • Run unit tests:
        • mdk phpunit -u mod/assign/tests/locallib_test.php
        • mdk phpunit -u mod/assign/tests/lib_test.php
      Show
      Hint: With the user that you grade, make their email something you can access then run cron when prompted to below to see the email come through and confirm it works. Test One: Create an assignment. Submit something as a student. Edit grade (marker, feedback, whatever) and set 'notify student: yes'. Run cron, php admin/cli/cron.php ( note: you may have to wait up to a minute before running this if you have run it recently) Ensure that notifications is sent. Edit the grade again and set 'notify student: yes' Run cron, php admin/cli/cron.php ( note: you may have to wait up to a minute before running this if you have run it recently) Ensure that notification is sent. Test Two: Use quick-grading from the assignment page to change a students grade. (ensure at the bottom, notify student is set to YES) Hit enter or the quick-save button. Run cron, php admin/cli/cron.php ( note: you may have to wait up to a minute before running this if you have run it recently) Should receive a email. Repeat the above but change notify student to NO. Should NOT receive any emails. Probably wise to grade the same assignment again but this time set 'notify student: no' and make sure it doesn't send too. Test Three: Run unit tests: mdk phpunit -u mod/assign/tests/locallib_test.php mdk phpunit -u mod/assign/tests/lib_test.php
    • Affected Branches:
      MOODLE_27_STABLE, MOODLE_28_STABLE
    • Fixed Branches:
      MOODLE_27_STABLE, MOODLE_28_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-46442-master
    • Sprint:
      FRONTEND Sprint 15

      Description

      This issue is originated from MDL-33600

      Reason: once a submission is set to 'notify students: yes', it gets marked as 'mailed', and cannot be mailed again if a grader wants to update it later. This makes the control select box meaningless since it works only the very first time.

      Use case: a grader sets 'fail' grade with some feedback to a student, he/she therefore has to improve the submission, and then the grader intends to update the grade and feedback.

      Testing instructions:
      1. Create an assignment.
      2. Submit something as a student.
      3. Edit grade (marker, feedback, whatever) and set 'notify student: yes'.
      4. Ensure that notifications is sent.
      5. Edit the grade again and set 'notify student: yes'
      6. Ensure that notification is not sent.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              zac Zachary Durber
              Reporter:
              pavel.m.sokolov Pavel Sokolov
              Peer reviewer:
              Andrew Nicols
              Integrator:
              Dan Poltawski
              Tester:
              Damyon Wiese
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
              Votes:
              26 Vote for this issue
              Watchers:
              28 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                12/Jan/15