Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-46446

Coding style problems in /rating

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.7.1
    • Fix Version/s: 2.8
    • Component/s: Ratings
    • Labels:
    • Testing Instructions:
      Hide

      This is all comment editing and code reformatting so theoretically no testing should be required. It would still probably be a good idea to turn on ratings for a rateable activity (forum, glossary) and check that no errors are displayed. As an admin you should be able to click on the aggregate and view the rating detail popup.

      Show
      This is all comment editing and code reformatting so theoretically no testing should be required. It would still probably be a good idea to turn on ratings for a rateable activity (forum, glossary) and check that no errors are displayed. As an admin you should be able to click on the aggregate and view the rating detail popup.
    • Affected Branches:
      MOODLE_27_STABLE
    • Fixed Branches:
      MOODLE_28_STABLE
    • Epic Link:
    • Pull from Repository:
    • Pull Master Branch:
      MDL-46446_rating_style
    • Pull Master Diff URL:

      Description

      There are currently 159 error(s) and 199 warning(s).

        Attachments

          Issue Links

          blocks

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-46447 /rating/rate.php Non-ajax file returning JSON data

          • Minor - Minor loss of function where workaround is possible
          • Closed

          Improvement - An enhancement to an existing Moodle feature. MDL-46448 /rating/rate_ajax.php figures out the updated rating aggregate even if the user cannot see it

          • Minor - Minor loss of function where workaround is possible
          • Closed
          Testing discovered

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-46447 /rating/rate.php Non-ajax file returning JSON data

          • Minor - Minor loss of function where workaround is possible
          • Closed

          Improvement - An enhancement to an existing Moodle feature. MDL-46448 /rating/rate_ajax.php figures out the updated rating aggregate even if the user cannot see it

          • Minor - Minor loss of function where workaround is possible
          • Closed

            Activity

              People

              Assignee:
              andyjdavis Andrew Davis
              Reporter:
              andyjdavis Andrew Davis
              Peer reviewer:
              Simey Lameze
              Integrator:
              Sam Hemelryk
              Tester:
              Mark Nelson
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                10/Nov/14