Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-46448

/rating/rate_ajax.php figures out the updated rating aggregate even if the user cannot see it

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.6.4
    • Fix Version/s: 2.8
    • Component/s: Ratings
    • Labels:
    • Testing Instructions:
      Hide

      Create a forum with ratings enabled. Set the rating aggregate to average.

      Go to the course capabilities and make sure that students can submit ratings. Filter on the word "rate" and it should be apparent which capabilities they need. They are moodle/rating:rate and mod/forum:rate.

      As a student and as teacher/admin post in the forum (ie you should have two posts, one from each user).

      When viewing the other user's post you should be able to rate. Check that no submit button is visible. If it is, you have ajax disabled so turn it on.

      Each user should be able to rate the other user's post.

      Student should not see an aggregate.

      Teacher/admin should see an aggregate that is updated after they submit a rating.

      Show
      Create a forum with ratings enabled. Set the rating aggregate to average. Go to the course capabilities and make sure that students can submit ratings. Filter on the word "rate" and it should be apparent which capabilities they need. They are moodle/rating:rate and mod/forum:rate. As a student and as teacher/admin post in the forum (ie you should have two posts, one from each user). When viewing the other user's post you should be able to rate. Check that no submit button is visible. If it is, you have ajax disabled so turn it on. Each user should be able to rate the other user's post. Student should not see an aggregate. Teacher/admin should see an aggregate that is updated after they submit a rating.
    • Affected Branches:
      MOODLE_26_STABLE
    • Fixed Branches:
      MOODLE_28_STABLE
    • Pull Master Branch:
      MDL-46448_rating_ajax2

      Description

      We are bothering to retrieve the updated rating aggregate even if the user lacks the capability to see it. We don't actually return it to the user if they can't see it, we just retrieve it then don't do anything with it.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              andyjdavis Andrew Davis
              Reporter:
              andyjdavis Andrew Davis
              Peer reviewer:
              Simey Lameze
              Integrator:
              Marina Glancy
              Tester:
              Jetha Chan
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                10/Nov/14