[MDL-46456] Javascript error when creating/editing an external tool - Moodle Tracker

XML

Word

Printable

Affected Branches:
MOODLE_28_STABLE
Fixed Branches:
MOODLE_28_STABLE
Pull from Repository:
https://github.com/aolley/moodle.git
Pull Master Branch:
~~MDL-46456~~
Pull Master Diff URL:
https://github.com/aolley/moodle/compare/moodle:master...MDL-46456
Testing Instructions:

Hide

1. Click 'add an activity or resource' from a course homepage
2. Choose ‘external tool’ and click add
3. Click 'show more' to see the editor for the activity description
4. Attempt to insert an Image using the editor
normal functionality.

Expected: You should be able to browse repositories.
Actual: Clicking 'Browse repositories' does nothing.

Show
1. Click 'add an activity or resource' from a course homepage 2. Choose ‘external tool’ and click add 3. Click 'show more' to see the editor for the activity description 4. Attempt to insert an Image using the editor normal functionality. Expected: You should be able to browse repositories. Actual: Clicking 'Browse repositories' does nothing.

Looks like a regression caused by ~~MDL-44902~~. A Y.one call added in the mod_form.js refers to #modstandardgrade instead of #id_modstandardgrade.

JS error causes filepicker and other JS elements to not work.

is a regression caused by

MDL-44902 Several additions to External Tool (LTI)

Participants:: Adam Olley, Adrian Greeve, CiBoT, Dan Poltawski, David Monllaó

Component watchers:: Jake Dallimore, Ilya Tregubov, Kevin Percy, Mathew May, Mihail Geshoski, Shamim Rezaie