Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-46472

Upgrade to 2.7 stuck in 'upgrade database now' loop with undeletable themes

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. Install a brand new 2.6 site
      2. Upgrade to 2.7
      3. Go to site admin -> plugins -> plugins overview
      4. Uninstall 'theme_formfactor'
      5. After uninstalling it you will be redirected to the 'Plugins check' page to upgrade moodle according to the last changes in the system
      6. You SHOULD see a list of themes with a 'To be deleted' status
      7. Press 'Upgrade Moodle database now'
      8. After upgrade, delete all of the 'Disabled' themes one by one (sorry)
      9. You SHOULD be able to kill 'em all
      Show
      Install a brand new 2.6 site Upgrade to 2.7 Go to site admin -> plugins -> plugins overview Uninstall 'theme_formfactor' After uninstalling it you will be redirected to the 'Plugins check' page to upgrade moodle according to the last changes in the system You SHOULD see a list of themes with a 'To be deleted' status Press 'Upgrade Moodle database now' After upgrade, delete all of the 'Disabled' themes one by one (sorry) You SHOULD be able to kill 'em all
    • Affected Branches:
      MOODLE_27_STABLE
    • Fixed Branches:
      MOODLE_27_STABLE, MOODLE_28_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-46472_master
    • Sprint:
      BACKEND Sprint 19
    • Issue size:
      Medium

      Description

      While upgrading to 2.7.1 from 2.6.2+, I came across this loop which can only be removed by manually deleting rows from the database. I experienced this on three upgrades on different servers.

      Steps to reproduce (more or less, as I didn't write them down at the time but a short while after):

      1. Upgraded from 2.6.2+ to 2.7. No problems encountered.

      2. Clicked Notifications, clicked 'Check for updated plugins'. It lists the following themes (only one at this point):

      Themes

      • Simple (Missing from disk)

      I click 'Uninstall' next to Simple, then Continue.

      3. Plugin is uninstalled without problems.

      4. Page redirects to Plugins Check screen, showing 29 plugins requiring my attention. Some are missing from disk (due to upgrade: this is expected), btu most are themes 'to be deleted'.

      5. Click 'Upgrade Moodle database now'.

      6. Page redirects to Plugins Overview: 'to be deleted' plugins are still present but 'disabled'.

      7. Uninstalling one of the themes (e.g. Afterburner) 'succeeds'.

      8. I am taken back to #4, but now there are only 28 plugins requiring my attention.

      9. This can continue until there are only two themes left, 'standard' and 'standardold', which cannot be deleted.

      To remove the final two themes from the database (as they definitely don't exist on disk):

      Look in 'mdl_config_plugins', for an entry called 'theme_standard' in the 'plugin' column, and delete it. Same for 'theme_standardold'.

      Reporting as per Dan Poltawski's request: https://twitter.com/SDCMoodle/status/485051398934249472

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              dmonllao David Monllaó
              Reporter:
              vaughany Paul Vaughan
              Peer reviewer:
              Dan Poltawski
              Integrator:
              Andrew Nicols
              Tester:
              John Okely
              Participants:
              Component watchers:
              Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Matteo Scaramuccia, Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Bas Brands
              Votes:
              6 Vote for this issue
              Watchers:
              17 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                12/Jan/15