Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-46486

coursecat::get_all_visible breaks with fatal error

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.6.3, 2.6.4, 2.7, 2.7.1
    • Fix Version/s: 2.7.4, 2.8.2
    • Component/s: Libraries
    • Labels:

      Description

      Fatal error: Call to undefined method coursecat::get_all_ids() in S:\SVN\moodle\2.6\trunk\moodle\lib\coursecatlib.php

      As far as I can tell get_all_ids isn't defined anywhere within coursecat. A search on the entire codebase turns up only this one reference.

      From my investigation it looks like the get_all_ids call was completely removed in the early development of the coursecat (see https://github.com/moodle/moodle/commit/15d50fffd8d23696334fb9f7a1fb12896eae1ce6 ).

      The comments for that commit and the actual changes that took place are completely out of whack (the comment says it removed the get_all_visible function, but it is clearly still there).

      Clearly the function should just be removed as it's completely broken anyways (and as such there should be no code that is relying on it), but maybe the entire library should be given another peer review to see if there are any other remnants that were missed...

        Attachments

          Activity

            People

            Assignee:
            marina Marina Glancy
            Reporter:
            jmlsteele Jody Steele
            Peer reviewer:
            Ankit Agarwal
            Integrator:
            Sam Hemelryk
            Tester:
            Zachary Durber
            Participants:
            Component watchers:
            Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              12/Jan/15