Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Minor
-
Resolution: Fixed
-
Affects Version/s: 2.6.3, 2.6.4, 2.7, 2.7.1
-
Component/s: Libraries
-
Testing Instructions:
-
Affected Branches:MOODLE_26_STABLE, MOODLE_27_STABLE
-
Fixed Branches:MOODLE_27_STABLE, MOODLE_28_STABLE
-
Pull from Repository:
-
Pull Master Branch:wip-
MDL-46486-master -
Pull Master Diff URL:
Description
Fatal error: Call to undefined method coursecat::get_all_ids() in S:\SVN\moodle\2.6\trunk\moodle\lib\coursecatlib.php
As far as I can tell get_all_ids isn't defined anywhere within coursecat. A search on the entire codebase turns up only this one reference.
From my investigation it looks like the get_all_ids call was completely removed in the early development of the coursecat (see https://github.com/moodle/moodle/commit/15d50fffd8d23696334fb9f7a1fb12896eae1ce6 ).
The comments for that commit and the actual changes that took place are completely out of whack (the comment says it removed the get_all_visible function, but it is clearly still there).
Clearly the function should just be removed as it's completely broken anyways (and as such there should be no code that is relying on it), but maybe the entire library should be given another peer review to see if there are any other remnants that were missed...