Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-46498

Assignment grading status being set to Graded before marking workflow is set to released

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      Test 1
      1. Create an assignment with the setting ‘Use marking workflow’ set to yes.
      2. As a student make a submission.
      3. As a teacher go to mark the submission, set ‘Marking workflow state’ to ‘In review’ and provide some feedback.
      4. As the teacher view the student's grade and make sure that the ‘Grading status’ is set to ‘In review’.
      5. As the student view the assignment.
      6. Make sure that the ‘Grading status’ is set to ‘In review’.
      7. Confirm there is no header 'Feedback' below showing the grade and feedback the teacher gave.
      8. View your my profile page (my/index.php) and click on where it states “You have assignments that need attention” to expand the box.
      9. Make sure that the submission states “Submitted for grading, In review”
      10. As the teacher repeat the above steps for all the other 'Marking workflow state' settings (except 'Released'), but this time instead of seeing 'In review' it should show you the state you set it to.
      Test 2
      1. Create an assignment with the setting ‘Use marking workflow’ set to yes.
      2. As a student make a submission.
      3. As a teacher go to mark the submission, set ‘Marking workflow state’ to ‘Released’ and provide some feedback.
      4. As the teacher view the student’s submission again and confirm that the ‘Grading status’ is set to ‘Released’.
      5. Log in as the student and view the assignment.
      6. Make sure that the ‘Grading status’ is set to ‘Released’ and you can view the feedback below.
      7. View your my profile page (my/index.php) and click on where it states “You have assignments that need attention” to expand the box.
      8. Make sure that the submission states “Submitted for grading, Released”.
      Test 3
      1. Create an assignment with the setting ‘Use marking workflow’ set to yes.
      2. As a student make a submission.
      3. As a teacher go to mark the submission ensuring you set ‘Marking workflow state’ to ‘Released’ and provide some feedback.
      4. Remark the assignment and change the marking workflow to anything except 'Released'.
      5. Log in as a student and confirm you can not check the feedback.
      6. As the teacher go to mark the assignment again and confirm the previous mark you gave is still listed.
      Test 4
      1. Run all the unit tests in the mod/assign/tests folder.
      Test 5
      1. Run all the behat tests with the tag @mod_assign.
      Show
      Test 1 Create an assignment with the setting ‘Use marking workflow’ set to yes. As a student make a submission. As a teacher go to mark the submission, set ‘Marking workflow state’ to ‘In review’ and provide some feedback. As the teacher view the student's grade and make sure that the ‘Grading status’ is set to ‘In review’. As the student view the assignment. Make sure that the ‘Grading status’ is set to ‘In review’. Confirm there is no header 'Feedback' below showing the grade and feedback the teacher gave. View your my profile page (my/index.php) and click on where it states “You have assignments that need attention” to expand the box. Make sure that the submission states “Submitted for grading, In review” As the teacher repeat the above steps for all the other 'Marking workflow state' settings (except 'Released'), but this time instead of seeing 'In review' it should show you the state you set it to. Test 2 Create an assignment with the setting ‘Use marking workflow’ set to yes. As a student make a submission. As a teacher go to mark the submission, set ‘Marking workflow state’ to ‘Released’ and provide some feedback. As the teacher view the student’s submission again and confirm that the ‘Grading status’ is set to ‘Released’. Log in as the student and view the assignment. Make sure that the ‘Grading status’ is set to ‘Released’ and you can view the feedback below. View your my profile page (my/index.php) and click on where it states “You have assignments that need attention” to expand the box. Make sure that the submission states “Submitted for grading, Released”. Test 3 Create an assignment with the setting ‘Use marking workflow’ set to yes. As a student make a submission. As a teacher go to mark the submission ensuring you set ‘Marking workflow state’ to ‘Released’ and provide some feedback. Remark the assignment and change the marking workflow to anything except 'Released'. Log in as a student and confirm you can not check the feedback. As the teacher go to mark the assignment again and confirm the previous mark you gave is still listed. Test 4 Run all the unit tests in the mod/assign/tests folder. Test 5 Run all the behat tests with the tag @mod_assign.
    • Affected Branches:
      MOODLE_26_STABLE, MOODLE_27_STABLE, MOODLE_28_STABLE
    • Fixed Branches:
      MOODLE_27_STABLE, MOODLE_28_STABLE
    • Pull Master Branch:
      MDL-46498_master
    • Sprint:
      BACKEND Sprint 19, Team B Sprint 1
    • Issue size:
      Medium

      Description

      2 other issues have identified notifications being sent to students about assignment grades being provided before the grades are released using the workflow (https://tracker.moodle.org/browse/MDL-45324) and (https://tracker.moodle.org/browse/MDL-46062).

      In-system notifications should also be improved for the workflow routine as well: the Grading status 'Graded' is shown to students in both the Course overview block and the Assignment submission page, even through they have no way of seeing the grade. This can cause confusion and a whole pile of traffic to an instructor because nothing gets students riled up like trying to find out their grades and not being able to.

      Easiest solution would be to keep the grading status at 'Not graded' until the marking workflow has been set to 'Released'.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              markn Mark Nelson
              Reporter:
              vandaleh Dave Laurie
              Peer reviewer:
              Damyon Wiese
              Integrator:
              Dan Poltawski
              Tester:
              Frédéric Massart
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
              Votes:
              5 Vote for this issue
              Watchers:
              17 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                12/Jan/15