Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-46585

String deprecation process (starting with deprecating 'hidden')

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Unfortunately it's difficult to check that removed string is actually not used. I guess behat tests and approval from component leads should be sufficient

      Testing string deprecation:

      1. insert echo get_string('hidden', 'calendar'); somewhere, render the page and make sure debugging message is displayed
      2. add some existing or non-existing strings to lang/en/deprecated.txt, make sure unittest lib/tests/string_manager_standard_test.php passes or fails
      Show
      Unfortunately it's difficult to check that removed string is actually not used. I guess behat tests and approval from component leads should be sufficient Testing string deprecation: insert echo get_string('hidden', 'calendar'); somewhere, render the page and make sure debugging message is displayed add some existing or non-existing strings to lang/en/deprecated.txt, make sure unittest lib/tests/string_manager_standard_test.php passes or fails
    • Affected Branches:
      MOODLE_27_STABLE
    • Fixed Branches:
      MOODLE_28_STABLE
    • Pull Master Branch:
      wip-MDL-46585-master

      Description

      The issue first was created to deal with 6 unnecessary 'hidden' strings but grew up into string deprecation process.

      lang/en/badges.php:$string['hidden'] = 'Hidden';
      lang/en/calendar.php:$string['hidden'] = 'hidden';
      lang/en/portfolio.php:$string['hidden'] = 'Hidden';
      lang/en/question.php:$string['hidden'] = 'Hidden';
      lang/en/repository.php:$string['hidden'] = 'Hidden';
      lang/en/role.php:$string['hidden'] = 'Hidden';
      

      Two "hidden"s remain because they are currently used:

      lang/en/grades.php:$string['hidden'] = 'Hidden';
      mod/scorm/lang/en/scorm.php:$string['hidden'] = 'Hidden';
      

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              marina Marina Glancy
              Reporter:
              marina Marina Glancy
              Peer reviewer:
              Tim Hunt Tim Hunt
              Integrator:
              Dan Poltawski Dan Poltawski
              Tester:
              John Okely John Okely
              Participants:
              Component watchers:
              Yuliya Bozhko, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona), Andrew Lyons, Dongsheng Cai, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, David Mudrák (@mudrd8mz), Helen Foster, Víctor Déniz Falcón, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona), Tim Hunt, Andrew Lyons, Dongsheng Cai, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Tim Hunt, Andrew Lyons, Dongsheng Cai, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                10/Nov/14