Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-46585

String deprecation process (starting with deprecating 'hidden')

XMLWordPrintable

    • MOODLE_27_STABLE
    • MOODLE_28_STABLE
    • wip-MDL-46585-master
    • Hide

      Unfortunately it's difficult to check that removed string is actually not used. I guess behat tests and approval from component leads should be sufficient

      Testing string deprecation:

      1. insert echo get_string('hidden', 'calendar'); somewhere, render the page and make sure debugging message is displayed
      2. add some existing or non-existing strings to lang/en/deprecated.txt, make sure unittest lib/tests/string_manager_standard_test.php passes or fails
      Show
      Unfortunately it's difficult to check that removed string is actually not used. I guess behat tests and approval from component leads should be sufficient Testing string deprecation: insert echo get_string('hidden', 'calendar'); somewhere, render the page and make sure debugging message is displayed add some existing or non-existing strings to lang/en/deprecated.txt, make sure unittest lib/tests/string_manager_standard_test.php passes or fails

      The issue first was created to deal with 6 unnecessary 'hidden' strings but grew up into string deprecation process.

      lang/en/badges.php:$string['hidden'] = 'Hidden';
      		 
      lang/en/calendar.php:$string['hidden'] = 'hidden';
      		 
      lang/en/portfolio.php:$string['hidden'] = 'Hidden';
      		 
      lang/en/question.php:$string['hidden'] = 'Hidden';
      		 
      lang/en/repository.php:$string['hidden'] = 'Hidden';
      		 
      lang/en/role.php:$string['hidden'] = 'Hidden';

      Two "hidden"s remain because they are currently used:

      lang/en/grades.php:$string['hidden'] = 'Hidden';
      		 
      mod/scorm/lang/en/scorm.php:$string['hidden'] = 'Hidden';

            marina Marina Glancy
            marina Marina Glancy
            Tim Hunt Tim Hunt
            Dan Poltawski Dan Poltawski
            John Okely John Okely
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.