Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-46631

Bootstrap notification logic inconsistent with core

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Duplicate
    • Affects Version/s: 2.8
    • Fix Version/s: None
    • Component/s: Themes
    • Labels:
      None

      Description

      Currently:

      • core_renderer::notification accepts either a string of classes to use verbatim, or an array of strings to join with spaces to use on resulting notification HTML.
        • It should be noted that this last use case is NOT DOCUMENTED.
      • theme_bootstrapbase_core_renderer::notification accepts a class string, and does not handle an array being passed.
        • The passed class string never actually makes it into the resulting HTML, it is instead mapped to a "suitable" bootstrap class. If no mapping exists, the passed class string is discarded.
        • Not handling an array of classes hides functionality.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              jethac Jetha Chan
              Reporter:
              jethac Jetha Chan
              Participants:
              Component watchers:
              Bas Brands
              Votes:
              1 Vote for this issue
              Watchers:
              1 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: