Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-46633

Chat send button gets stuck on "sending" if message is empty

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 2.6.4, 2.7.1, 2.8
    • Fix Version/s: 2.6.5, 2.7.2
    • Component/s: Chat
    • Labels:
    • Affected Branches:
      MOODLE_26_STABLE, MOODLE_27_STABLE, MOODLE_28_STABLE
    • Fixed Branches:
      MOODLE_26_STABLE, MOODLE_27_STABLE
    • Pull from Repository:
    • Pull Master Branch:
    • Pull Master Diff URL:
    • Testing Instructions:
      Hide

      1. Enter into a chat
      2. Don't type anything into chat box
      3. Clicking over send should not change the button value to 'sending'
      4. Send method must not be triggered if the message is blank
      5. Regression test - Make sure both non-empty messages are sent ok and the "Beep" functionality works even if the message is blank.

      Show
      1. Enter into a chat 2. Don't type anything into chat box 3. Clicking over send should not change the button value to 'sending' 4. Send method must not be triggered if the message is blank 5. Regression test - Make sure both non-empty messages are sent ok and the "Beep" functionality works even if the message is blank.

      Description

      Reproduction steps:

      1. Enter a chat
      2. Don't type anything in chat box
      3. Click send

        Attachments

          Issue Links

          Discovered while testing

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-46465 Code Checker reports an impressive 1427 errors and 423 warnings just in mod/chat

          • Minor - Minor loss of function where workaround is possible
          • Closed

            Activity

              People

              Assignee:
              shashitechno Shashikant vaishnav
              Reporter:
              johno John Okely
              Peer reviewer:
              Damyon Wiese Damyon Wiese
              Integrator:
              Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
              Tester:
              John Okely John Okely
              Participants:
              Component watchers:
              Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                8/Sep/14