[MDL-46633] Chat send button gets stuck on "sending" if message is empty - Moodle Tracker

XML

Word

Printable

Affected Branches:
MOODLE_26_STABLE, MOODLE_27_STABLE, MOODLE_28_STABLE
Fixed Branches:
MOODLE_26_STABLE, MOODLE_27_STABLE
Pull from Repository:
https://github.com/shashirepo/moodle/
Pull Master Branch:
~~MDL-46633~~
Pull Master Diff URL:
https://github.com/shashirepo/moodle/compare/MDL-46633
Testing Instructions:

Hide

1. Enter into a chat
2. Don't type anything into chat box
3. Clicking over send should not change the button value to 'sending'
4. Send method must not be triggered if the message is blank
5. Regression test - Make sure both non-empty messages are sent ok and the "Beep" functionality works even if the message is blank.

Show
1. Enter into a chat 2. Don't type anything into chat box 3. Clicking over send should not change the button value to 'sending' 4. Send method must not be triggered if the message is blank 5. Regression test - Make sure both non-empty messages are sent ok and the "Beep" functionality works even if the message is blank.

Reproduction steps:

Discovered while testing

MDL-46465 Code Checker reports an impressive 1427 errors and 423 warnings just in mod/chat

Participants:: CiBoT, Damyon Wiese, Eloy Lafuente (stronk7), Jetha Chan, John Okely, Shashikant vaishnav

Component watchers:: Amaia Anabitarte, Carlos Escobedo, Laurent David, Mikel Martín Corrales, Sabina Abellan, Sara Arjona (@sarjona)